Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Descend from the alps/swagger api view #31320

Merged
merged 17 commits into from
Nov 13, 2024
Merged

Descend from the alps/swagger api view #31320

merged 17 commits into from
Nov 13, 2024

Conversation

chidozieononiwu
Copy link
Member

This adds a job for identifying swagger files in a given pull-request and generate relevant swagger APIView token artifacts.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 29, 2024 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is awaiting ARM reviewer feedback (label: WaitForARMFeedback).
    To learn when this PR will get reviewed, see ARM review queue at aka.ms/azsdk/pr-arm-review
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide. In addition, refer to step 4 in the PR workflow diagram

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 29, 2024 •
edited
Loading

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@chidozieononiwu chidozieononiwu self-assigned this Oct 29, 2024
@chidozieononiwu chidozieononiwu marked this pull request as draft October 29, 2024 21:25
@chidozieononiwu chidozieononiwu force-pushed the descendFromTheAlps/SwaggerAPIView branch from ad604d4 to 1588bf8 Compare October 29, 2024 21:44
@chidozieononiwu chidozieononiwu force-pushed the descendFromTheAlps/SwaggerAPIView branch 4 times, most recently from 7d12a35 to a686d6e Compare October 29, 2024 23:08
This was referenced Oct 29, 2024
Closed
Closed
Closed
Closed
Closed
Closed
@chidozieononiwu chidozieononiwu force-pushed the descendFromTheAlps/SwaggerAPIView branch 4 times, most recently from aa18a6b to 60e3173 Compare October 30, 2024 00:21
@chidozieononiwu chidozieononiwu force-pushed the descendFromTheAlps/SwaggerAPIView branch from 13998c6 to 85e506a Compare November 13, 2024 17:41
@AzureRestAPISpecReview AzureRestAPISpecReview added the TypeSpec Authored with TypeSpec label Nov 13, 2024
@chidozieononiwu chidozieononiwu force-pushed the descendFromTheAlps/SwaggerAPIView branch from 85e506a to e5639d5 Compare November 13, 2024 18:03
@chidozieononiwu chidozieononiwu force-pushed the descendFromTheAlps/SwaggerAPIView branch from e5639d5 to 7980b0c Compare November 13, 2024 18:27
@weshaggard
Copy link
Member

weshaggard commented Nov 13, 2024 •
edited
Loading

@mikeharder are there plans to bubble up errors for things like the TypeSpec Validation failures? If I didn't understand how to go digging deep into the collapsed logs I wouldn't have been able to easily figure out what the error is for this PR. Of course, this one could be worse given it is making common file changes and essentially runs tsv all, but it is still difficult to figure out the issue.

@chidozieononiwu chidozieononiwu force-pushed the descendFromTheAlps/SwaggerAPIView branch from 991e200 to a465ebb Compare November 13, 2024 22:05
@AzureRestAPISpecReview AzureRestAPISpecReview removed ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager ARMReview ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review TypeSpec Authored with TypeSpec labels Nov 13, 2024
@openapi-pipeline-app openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 13, 2024
@chidozieononiwu chidozieononiwu merged commit 00d50cb into Azure:main Nov 13, 2024
38 of 40 checks passed
digvijaymali94 pushed a commit to digvijaymali94/azure-rest-api-specs that referenced this pull request Dec 17, 2024
@chidozieononiwu @digvijaymali94
Descend from the alps/swagger api view (Azure#31320)
56d7181 
* Test retrieval of APIView Changed Files

* Add Script for Creating Swagger APIViews

* Add artificial change to swagger file

* Add GitHub Actions Pipeline

* Allow workflow work on pull requests

* Update GitHub Workflow

* Remove PR trigger

* Add Script for Creating Swagger APIView

* Call APIView API

* Add Github location flag

* Use unique artifact name

* Split into multi-job workflow

* Switch APIview Pipeline to DevOps

* Remove the GitHub workflows

* Minor Change to API

* Use Same Script for APIView

* Changes to pipeline config and script
grangasamy-msft pushed a commit that referenced this pull request Feb 5, 2025
@chidozieononiwu @grangasamy-msft
Descend from the alps/swagger api view (#31320)
a87e12c 
* Test retrieval of APIView Changed Files

* Add Script for Creating Swagger APIViews

* Add artificial change to swagger file

* Add GitHub Actions Pipeline

* Allow workflow work on pull requests

* Update GitHub Workflow

* Remove PR trigger

* Add Script for Creating Swagger APIView

* Call APIView API

* Add Github location flag

* Use unique artifact name

* Split into multi-job workflow

* Switch APIview Pipeline to DevOps

* Remove the GitHub workflows

* Minor Change to API

* Use Same Script for APIView

* Changes to pipeline config and script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard left review comments

@maririos maririos maririos left review comments

@raych1 raych1 raych1 left review comments

@praveenkuttappan praveenkuttappan praveenkuttappan left review comments

@razvanbadea-msft razvanbadea-msft razvanbadea-msft left review comments

@mikeharder mikeharder mikeharder approved these changes

@benbp benbp Awaiting requested review from benbp benbp is a code owner

@ckairen ckairen Awaiting requested review from ckairen

Assignees

@chidozieononiwu chidozieononiwu

Labels
BreakingChange-Python-Sdk WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
Projects
Azure SDK EngSys 🤖🧠
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@chidozieononiwu @raych1 @azure-sdk @weshaggard @mikeharder @maririos @praveenkuttappan @razvanbadea-msft @AzureRestAPISpecReview