-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Microsoft.DependencyMap API public preview versions #31655
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Generated ApiView
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
Please fix the TypeSpec Validation and LintDiff errors first. Also, please make sure to through OpenAPI specs PR creation guidance and follow the instructions there. Are you introducing brand new APIs, or are you adding a new version based on a previous version? It's hard to tell what are new for this PR. |
We have an API version which is in private preview. We are introducing a new version which is essentially the same as the previous one, but will be used for public preview without a feature flag. I have removed the private preview version from the PR, that is already merged into RPSaaSMaster branch in the private repo. This PR now only contains the new version |
Presumably your specs in the private REST repo have already been reviewed and signed off by ARM (IOW, the PR that added them has the ARMSignedOff label). If so, then please move your APIs to the public repo unchanged in one PR (include a comment with a link back to the ARMSignedOff PR in the private repo) and then make a separate PR for adding the new API. Or if you prefer, add the new API version in the private repo first, get signoff and merge, then move it to the public repo in a new PR. Either way, when you move APIs across, don't make any changes, and always include a comment explaining what you are doing, including a link back to the previous PR in which that API version was reviewed and signed off by ARM. |
Understood, thanks. I'll close this PR and raise a new one once the PR is approved and merged in the private repository |
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.