Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Operations and Enable CSharp SDK Generation for Workloads #31675

Merged
merged 34 commits into from
Dec 5, 2024
Merged

Adding Operations and Enable CSharp SDK Generation for Workloads #31675

merged 34 commits into from
Dec 5, 2024

Conversation

jaskisin
Copy link
Contributor

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Jaskirat Singh and others added 30 commits September 16, 2024 19:43
Adding Operation Id as required by PS
44dff8c
@jaskisin
Merge branch 'Azure:main' into workloadsapi20240901
08f81ed
@jaskisin
Merge branch 'Azure:main' into workloadsapi20240901
f1f6e5a
adding .NET SDK support
a9b7a87
adding operation and dotnet
326b197
@jaskisin
Merge branch 'main' into workloadsapi20240901
ed08301
Revert "adding operation and dotnet"
2b5f300 
This reverts commit 326b197.
change of csharp package
5bb2b34
Reapply "adding operation and dotnet"
3d950c1 
This reverts commit 2b5f300.
Change to UserAssignIdentity
097d78e
Revert "Change to UserAssignIdentity"
0d7f197 
This reverts commit 097d78e.
Change to UserAssignedIdentity
a4d7b31
Adding None for Identity
8f03eee
Change in the body name for request
b4a09a5
extending Operations in sapvirtualinstance
260caaa
Revert "Change in the body name for request"
3895cf2 
This reverts commit b4a09a5.
remove operations examples
89d35ab
Fix suggested by dotet pipeline
3abe6e5
Revert "Fix suggested by dotet pipeline"
9ec31e2 
This reverts commit 3abe6e5.
making operations as seperate file
0de7002
adding suppression with where
ac83cbe
@jaskisin
Merge branch 'main' into workloadsapi20240901
d5f1c56
@jaskisin
Merge branch 'Azure:main' into workloadsapi20240901
07b7806
Enabling the csharp sdk
801da4b
Add Operations namespace and define operations endpoint for SAP Virtu…
38236e2 
…al Instance
@jaskisin
Merge branch 'Azure:main' into workloadsapi20240901
990c655
Comment out Typespec C# configuration in tspconfig.yaml for SAP Virtu…
11273c1 
…al Instance
Add examples section for listing operations in SAP Virtual Instance s…
3c777b5 
…pecification
Comment out Typespec C# configuration in tspconfig.yaml for SAP Virtu…
ed8ae87 
…al Instance
Merge branch 'workloadsapi20240901' of https://github.com/jaskisin/az…
1ad5a77 
…ure-rest-api-specs into workloadsapi20240901
@AzureRestAPISpecReview AzureRestAPISpecReview added NotReadyForARMReview VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required and removed BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior labels Nov 27, 2024
@jaskisin jaskisin added BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior and removed VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required NotReadyForARMReview labels Nov 27, 2024
@jaskisin jaskisin force-pushed the workloadsapi20240901 branch from a88478a to e76c519 Compare November 29, 2024 03:32
@AzureRestAPISpecReview AzureRestAPISpecReview added NotReadyForARMReview VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required and removed BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior labels Nov 29, 2024
@jaskisin jaskisin added BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior and removed VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required NotReadyForARMReview labels Nov 29, 2024
@AzureRestAPISpecReview AzureRestAPISpecReview added NotReadyForARMReview VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required and removed BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior labels Nov 29, 2024
venu-sivanadham
venu-sivanadham approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@venu-sivanadham venu-sivanadham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jaskisin jaskisin added BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior and removed VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required NotReadyForARMReview labels Nov 29, 2024
@jaskisin
Copy link
Contributor Author

jaskisin commented Nov 29, 2024 •
edited
Loading

For dotnet, we need to create new directory as service has split the swagger/typespec at RT level, this will be done separately to dotnet sdk repo.

@pratikjoshi14 pratikjoshi14 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Dec 2, 2024
@jaskisin jaskisin added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Dec 5, 2024
@jaskisin jaskisin merged commit 4976ba2 into Azure:main Dec 5, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@venu-sivanadham venu-sivanadham venu-sivanadham approved these changes

@ajaygit158 ajaygit158 ajaygit158 approved these changes

Assignees
No one assigned
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review AzCoreIDC BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior BreakingChange-Go-Sdk BreakingChange-Go-Sdk-Approved PublishToCustomers Acknowledgement the changes will be published to Azure customers. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS TypeSpec Authored with TypeSpec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jaskisin @azure-sdk @venu-sivanadham @ajaygit158 @tadelesh @AzureRestAPISpecReview @pratikjoshi14