-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new property to AdvancedMessageReceivedEvent #32013
base: main
Are you sure you want to change the base?
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Generated ApiView
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
...entgrid/data-plane/Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json
Show resolved
Hide resolved
Hello Libba, |
Hello Libba, |
...zure.Messaging.EventGrid.SystemEvents/Microsoft.Communication/AzureCommunicationServices.tsp
Outdated
Show resolved
Hide resolved
...zure.Messaging.EventGrid.SystemEvents/Microsoft.Communication/AzureCommunicationServices.tsp
Outdated
Show resolved
Hide resolved
...zure.Messaging.EventGrid.SystemEvents/Microsoft.Communication/AzureCommunicationServices.tsp
Outdated
Show resolved
Hide resolved
...entgrid/data-plane/Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json
Show resolved
Hide resolved
...zure.Messaging.EventGrid.SystemEvents/Microsoft.Communication/AzureCommunicationServices.tsp
Outdated
Show resolved
Hide resolved
...zure.Messaging.EventGrid.SystemEvents/Microsoft.Communication/AzureCommunicationServices.tsp
Outdated
Show resolved
Hide resolved
...entgrid/data-plane/Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json
Outdated
Show resolved
Hide resolved
...zure.Messaging.EventGrid.SystemEvents/Microsoft.Communication/AzureCommunicationServices.tsp
Outdated
Show resolved
Hide resolved
specification/eventgrid/Azure.Messaging.EventGrid.SystemEvents/main.tsp
Outdated
Show resolved
Hide resolved
...entgrid/data-plane/Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json
Outdated
Show resolved
Hide resolved
...cation/eventgrid/data-plane/Microsoft.EventGrid/stable/2018-01-01/GeneratedSystemEvents.json
Outdated
Show resolved
Hide resolved
...zure.Messaging.EventGrid.SystemEvents/Microsoft.Communication/AzureCommunicationServices.tsp
Outdated
Show resolved
Hide resolved
...zure.Messaging.EventGrid.SystemEvents/Microsoft.Communication/AzureCommunicationServices.tsp
Outdated
Show resolved
Hide resolved
...zure.Messaging.EventGrid.SystemEvents/Microsoft.Communication/AzureCommunicationServices.tsp
Show resolved
Hide resolved
@@ -1227,13 +1227,13 @@ model AcsMessageMediaContent { | |||
/** Optional. The caption for the media object, if supported and provided */ | |||
caption?: string; | |||
|
|||
/** Optional. Set to true if the sticker is animated; false otherwise. */ | |||
/** Optional. Set to true if the sticker is animated; false otherwise. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...entgrid/data-plane/Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json
Outdated
Show resolved
Hide resolved
...zure.Messaging.EventGrid.SystemEvents/Microsoft.Communication/AzureCommunicationServices.tsp
Show resolved
Hide resolved
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts. |
…uired and optional according to CPM team.
11fc4dd
to
e3b80f8
Compare
Data Plane API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links
Getting help
write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.