Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge changes from main into release-web-2024-11-01 #32647

Open
wants to merge 760 commits into
base: release-web-2024-11-01
Choose a base branch
from
Open

Merge changes from main into release-web-2024-11-01 #32647

wants to merge 760 commits into from

Conversation

naveedaz
Copy link
Contributor

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

scottaddie and others added 30 commits January 9, 2025 11:11
@scottaddie
Rebranding of Azure AI Studio (Azure#32063)
4c56d55 
* Rebranding of Azure AI Studio

* Fix spelling error
@xuhumsft @nishil-bisht
@sagamzu @kingwil @nbatyrbb
Dev sentinel securityinsights microsoft.security insights 2024 10 01 …
008a07d 
…preview (Azure#31790)

* Copy files from preview/2024-04-01-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-10-01-preview

Updated the API version from preview/2024-04-01-preview to preview/2024-10-01-preview.

* Added tag for 2024-10-01-preview in readme file

* support odata search in listing product packages (Azure#31740)

* support odata search in listing product packages

* add new supported contentKind

* fix perttier errors

* Fix Data connectors API Typos (Azure#31806)

* Add PurviewAudit connector (Azure#31821)

* Add PurviewAudit connector

* prettier fix

* prettier fix

---------

Co-authored-by: Will King <[email protected]>

* resolve comments and fix the prettier issue (Azure#31965)

* Watchlist fix (Azure#32047)

* reorder TI parameter to address breaking change errors (Azure#32053)

---------

Co-authored-by: NISHILBISHT <[email protected]>
Co-authored-by: sagamzu <[email protected]>
Co-authored-by: kingwil <[email protected]>
Co-authored-by: Will King <[email protected]>
Co-authored-by: nbatyrbb <[email protected]>
@danieljurek
Don't check custom-words.txt (Azure#32065)
8a4eca6 
* ignore custom-words.txt

* test change to custom-words.txt

* Revert test change to custom-words.txt
@gigigoo0
Fix get polygon response schema (Azure#32061)
1737d89
@koyasu221b
Route 2024-07-01-preview update for RouteRange (Azure#32086)
9cda516 
* Update isSimplifiedPolygon

* Fix cspell

---------

Co-authored-by: Will Huang <[email protected]>
@weidongxu-microsoft
java, OpenAI.Inference, migrate to clientNamespace (Azure#31643)
b6075db
@dpwatrous
[Batch] Normalize mgmt plane doc links (Azure#32069)
f6fabb4 
Fixed some broken links, and normalized all doc URLs to
learn.microsoft.com without the en-us locale.
@dpwatrous
[Batch] Normalize data plane doc links (Azure#32070)
2f12237 
Fixed some broken links, and normalized all doc URLs to
learn.microsoft.com without the en-us locale.
@SpencerOfwiti
Update examples and descriptions and update ApiKeyNameParameter for N…
62f75b8 
…ginx swagger (Azure#32042)

* Update examples and descriptions for Nginx swagger

We recently merged this PR, [Nginx 2024 11 01 preview Azure#31409](Azure#31409), but we found out some examples and description were not desired. we just want to update these and have no functional changes

* Add missing periods in JSON descriptions.

* Add x-ms-parameter-location to apiKeyName

Add `"x-ms-parameter-location": "method"` property to `ApiKeyNameParameter` for easier AutoRest generation.
@chidozieononiwu
Update Source and Target Commit for APIView TypeSpec generation (Azur…
dc7fc98 
…e#32076)
@fangru2023 @kazrael2119
Fix the api descrption (Azure#31188)
e524180 
* decription fix.

* remove \n

* fix invalid armId.

* fix \n

* fix arm id.

* Create sdk-suppressions.yaml

* Update specification/standbypool/StandbyPool.Management/sdk-suppressions.yaml

* edit cSpell.json.

* edit cSpell.json.

---------

Co-authored-by: kazrael2119 <[email protected]>
@Renyx1219 @Shubham-9999-bot
Release Microsoft.DatabaseWatcher GA Version stable/2025-01-02 (Azure…
483f464 
…#32028)

* Add stable version 2025-01-02.

* Add examples for new API version.

* Update readme.md

* Add stable version 2025-01-02.

* Add examples for new API version.

* Update readme.md

* Fix TypeSpec Validation Error.

* Revert "Fix TypeSpec Validation Error."

This reverts commit 82c73af.

* Re-compile the code.

* Use eastus2 as example region.

* Update doc strings for consistence.

* Fix SpellCheck issue.

* Remove unused SqlVmTargetProperties in GA version.

---------

Co-authored-by: Yixiong Ren <[email protected]>
Co-authored-by: Shubham <[email protected]>
@l0lawrence
[eg] make req/optional more explicit in readme (Azure#32079)
9be3ccf 
* update

* update for clarity
@mjmadhu
PlaywrightTesting -Bringing common model in shared namespace (Azure#3…
0433add 
…2019)

* Created PlaywrightTesting.Shared namespace

* tsp format fixed
@FRL200 @Cherrett
Update default values and descriptions for Key Vault on API Version 2…
b92fe44 
…024-11-01 (Azure#31713)

* Copy files from stable/2023-07-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to stable/2024-11-01

Updated the API version from stable/2023-07-01 to stable/2024-11-01.

* Added tag for 2024-11-01 in readme file

* Removed unnecessary folder

* Update default values and descriptions for Key Vault (Azure#31683)

* Initial Changes to Spec

* Prettier ran

* Ran prettier

---------

Co-authored-by: Fernando Rauseo Landa <[email protected]>

* Ran prettier

* Ran prettier on all files

* Update managedHsm.json (Azure#31732)

* typo fix

---------

Co-authored-by: Fernando Rauseo Landa <[email protected]>
Co-authored-by: Daniel Cherrett <[email protected]>
@FRL200 @Cherrett @tadelesh
Release keyvault microsoft.key vault preview/2024 12 01 preview (Azur…
4ae5cdc 
…e#31796)

* Copy files from preview/2024-04-01-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-12-01-preview

Updated the API version from preview/2024-04-01-preview to preview/2024-12-01-preview.

* Added tag for 2024-12-01-preview in readme file

* Added Azure Managed HSM C SKUs to preview version (Azure#31733)

* Update managedHsm.json

* Update managedHsm.json

* Changes to update default values and description and prettier ran (Azure#31718)

Co-authored-by: Fernando Rauseo Landa <[email protected]>

* Update readme

* misc fix

* update tag

* resolve ci issue

* fixed typos and override words

---------

Co-authored-by: Fernando Rauseo Landa <[email protected]>
Co-authored-by: Daniel Cherrett <[email protected]>
Co-authored-by: Chenjie Shi <[email protected]>
@ChenxiJiang333 @msyyc
[Container Service] Update readme.python.md (Azure#32112)
a26af9a 
* Update readme.python.md

* fix cspell

---------

Co-authored-by: Yuchao Yan <[email protected]>
@JackTn
[BUG] Github Action For Sdk Suppressions (Azure#32124)
b262fe5 
* add filter suppression

* parse changefiles
@danieljurek
Spelling: Allow compound words, fix JSON syntax (Azure#32140)
5b9edd4
@azure-sdk @scbedd
remove erroneous package inclusion during package-properties evaluati…
f7e9063 
…on (Azure#32129)

Co-authored-by: Scott Beddall <[email protected]>
@magodo
Terraform: Update models to include ARG table selection feature and i…
3feb9e3 
…mport block export feature (Azure#31546)

* Terraform: Update models to include ARG table selection feature and import block export feature
@danieljurek
Remove extra space (Azure#32147)
f2adf4b
@ChenxiJiang333
Update readme.python.md (Azure#32150)
aa4ba9e
@chidozieononiwu
Add variables files (Azure#32101)
165586a
@dependabot @mikeharder
Bump @azure-tools/typespec-client-generator-cli (Azure#32110)
ca2053c 
Bumps the typespec-client-generator-cli group with 1 update in the / directory: [@azure-tools/typespec-client-generator-cli](https://github.com/Azure/azure-sdk-tools).


Updates `@azure-tools/typespec-client-generator-cli` from 0.14.2 to 0.15.1
- [Release notes](https://github.com/Azure/azure-sdk-tools/releases)
- [Commits](https://github.com/Azure/azure-sdk-tools/commits)

---
updated-dependencies:
- dependency-name: "@azure-tools/typespec-client-generator-cli"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: typespec-client-generator-cli
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mike Harder <[email protected]>
@azure-sdk @scbedd @benbp
Sync eng/common directory with azure-sdk-tools for PR 9635 (Azure#32169)
7e08d30 
* ensure that packages that come back from AdditionalValidationPackages are NOT counted as 'includedForValidation: true' if they also exist in the original 'these packages changed' set

Co-authored-by: Ben Broderick Phillips <[email protected]>

---------

Co-authored-by: Scott Beddall <[email protected]>
Co-authored-by: Scott Beddall <[email protected]>
Co-authored-by: Ben Broderick Phillips <[email protected]>
@mccoyp @maorleger
@mikeharder @gracewilcox @vcolin7 @tadelesh
[Key Vault] TypeSpec for Administration library (Azure#30239)
70672ea 
* Initial conversion from swagger

* Update main.tsp

* Update tspconfig.yaml

* Update models.tsp

* Update routes.tsp

* Remove unused client.tsp

* Use client.tsp

* Remove unused code

* Add exmaples folder

* Resolve validation; Remove client.tsp for now

* Only include relevant examples

* Emit Administration swagger from tsp

* Remove '-sdk' from generated swagger name

* Add 7.5 support

* Examples folder structure; add operationId/title to examples

* Regenerate swaggers from TSP

* Remove redundant existing swaggers

* Fix up tspconfig.yaml for validation errors

* Fix up LROs

* Update readme for administration.json in 7.5, 7.6-preview.1

* Move TSP directory into keyvault folder

* add typespec-ts to admin

* camelCase to kebab-case for setting-name path

* Use KeyVaultError; suppress method naming errors

* Update title

* Use + in path param to skip scope URL encoding

* generate metadata for ci

* Create BackupRestore directory

* Create RBAC directory

* Create Settings directory

* Unified Administration library for SDK gen; Common to facilitate

* @parameterVisibility to show required UpdateSettingRequest attribute

* Remove Administration tspconfig to avoid PR checks

* Add client.tsp for .NET to test validation

* Fix to reference Error

* Re-add config; suppress client.tsp warnings

* Restrict client customizations to .NET

* Revert "Update readme for administration.json in 7.5, 7.6-preview.1"

This reverts commit 1d0a2bb.

* Remove description newlines

* Add GetSetting example (was UpdateSetting in main)

* add customization for js

* Make Error nullable

* Templatize operations to use KeyVaultError

* Rebase; Azure.Core.nextLink -> TypeSpec.nextLink

* Make backup/restore bodies required

* Add README explaining directory structure

* go specific changes

* Restore Azure.Core.nextLink -> TypeSpec.nextLink

* TSP validation reformat

* TSP validation for Go client.tsp clients

* Correctly mark nullable attributes

* Correctly make Error model nullable

* Added Java configuration. Moved all imports to administration.tsp

* Revert "Added Java configuration. Moved all imports to administration.tsp"

This reverts commit e820e96.

* Added Java config back.

* add selectiveKeyRestoreStatus

* Rename `jobID` to `jobId` in selectiveKeyRestoreStatus route.

* Added @SharedRoute to restore status operations.

* Selective restore status example

* Run prettier

* cspell

* go tspconfig

* Allow 'azadmin' word

* Add additionalDirectories to tspconfig

* additionalDirectories for unified; TypeSpec.nextLink

* set correct values for typescript

* update go tspconfig

* fix module name for go tspconfig

---------

Co-authored-by: Maor Leger <[email protected]>
Co-authored-by: Mike Harder <[email protected]>
Co-authored-by: gracewilcox <[email protected]>
Co-authored-by: vcolin7 <[email protected]>
Co-authored-by: vcolin7 <[email protected]>
Co-authored-by: Chenjie Shi <[email protected]>
@tejasm-microsoft @msyyc
Feature/2025 03 01 stable (Azure#32062)
0d99a63 
* Copy files from preview/2024-12-18-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to stable/2025-03-01

Updated the API version from preview/2024-12-18-preview to stable/2025-03-01.

* Added tag for 2025-03-01 in readme file

* Resolves prettier errors

* add sdk-suppressins.yaml

* adds group quota related words to suppression list in cSpell

* change the case sensitivity of Suppressions

* spelling mistake with the word "supressions"

* fixes incorrect Ids in examples

---------

Co-authored-by: Yuchao Yan <[email protected]>
@ravigautam1896
updating the cpsell json (Azure#32157)
1b038fc 
Co-authored-by: Ravi Gautam <[email protected]>
@rajat-rastogi
Release communication email 2025 01 15 preview (Azure#32084)
f3ac3c7 
* Copy files from preview/2024-07-01-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2025-01-15-preview

Updated the API version from preview/2024-07-01-preview to preview/2025-01-15-preview.

* Added tag for 2025-01-15-preview in readme file

* Add new sender display name optional property
@naveedaz naveedaz requested review from JeffreyRichter and mikekistler and removed request for a team February 15, 2025 02:40
@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Feb 15, 2025 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ Your PR requires an API stewardship board review as it introduces a new API version (label: new-api-version). Schedule the review by following aka.ms/azsdk/onboarding/restapischedule.
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is awaiting ARM reviewer feedback (label: WaitForARMFeedback).
    To learn when this PR will get reviewed, see ARM review queue at aka.ms/azsdk/pr-arm-review
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ The required check named Swagger PrettierCheck has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

@openapi-pipeline-app openapi-pipeline-app
Copy link

PR validation pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview data-plane new-api-version resource-manager RPaaS SuppressionReviewRequired TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard is a code owner

@mikeharder mikeharder Awaiting requested review from mikeharder mikeharder is a code owner

@benbp benbp Awaiting requested review from benbp benbp is a code owner

@msyyc msyyc Awaiting requested review from msyyc msyyc is a code owner

@tadelesh tadelesh Awaiting requested review from tadelesh tadelesh is a code owner

@jsntcy jsntcy Awaiting requested review from jsntcy jsntcy is a code owner

@qiaozha qiaozha Awaiting requested review from qiaozha qiaozha is a code owner

@stankovski stankovski Awaiting requested review from stankovski stankovski is a code owner

@Juliehzl Juliehzl Awaiting requested review from Juliehzl Juliehzl is a code owner

@solankisamir solankisamir Awaiting requested review from solankisamir solankisamir is a code owner

@annatisch annatisch Awaiting requested review from annatisch annatisch is a code owner

@heaths heaths Awaiting requested review from heaths heaths is a code owner

@deyaaeldeen deyaaeldeen Awaiting requested review from deyaaeldeen deyaaeldeen is a code owner

@kristapratico kristapratico Awaiting requested review from kristapratico kristapratico is a code owner

@mssfang mssfang Awaiting requested review from mssfang mssfang is a code owner

@joseharriaga joseharriaga Awaiting requested review from joseharriaga joseharriaga is a code owner

@minhanh-phan minhanh-phan Awaiting requested review from minhanh-phan minhanh-phan is a code owner

@JeffreyRichter JeffreyRichter Awaiting requested review from JeffreyRichter JeffreyRichter is a code owner automatically assigned from Azure/api-stewardship-board

@mikekistler mikekistler Awaiting requested review from mikekistler mikekistler is a code owner automatically assigned from Azure/api-stewardship-board

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ARMReview data-plane new-api-version resource-manager RPaaS SuppressionReviewRequired TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.