[EngSys] apply some code clean up for test and samples-dev #32917
+5,331
−8,203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremymeng
requested review from
qiaozha,
MaryGao,
a team,
srnagar,
lmolkova,
hectorhdzg,
JacksonWeber,
harsimar,
MSNev,
Sid200026,
puagarwa,
ShreyaAnand,
dubiety,
andykao1213,
FlorianBorn71,
RamonArguelles,
dgetu,
mpodwysocki,
KarishmaGhiya,
HarshaNalluru,
minhanh-phan,
deyaaeldeen,
rhurey,
dargilco,
ganeshyb,
GraceBrigham,
glharper and
quentinRobinson
as code owners
github-actions
bot
added
EngSys
|
API change check API changes are not detected in this pull request. |
mpodwysocki
reviewed
Feb 7, 2025
| //////////////////////////////////////////////////////// | ||
| /////////////// Example for .byPage() //////////////// | ||
| //////////////////////////////////////////////////////// | ||
| /// ///////////////////////////////////////////////////// |
There was a problem hiding this comment.
I don't think this should be intentional here.
There was a problem hiding this comment.
yeah that's the result of formatting. We should probably rewrite it to block style to prevent this from happening
This PR applies @mpodwysocki's clean-up code for the whole repo to reduce diffs in snippets pull requests. ***NO_CI***
jeremymeng
force-pushed
the
engsys/samples-dev-cleanup
branch
from
1067dfb to
27f5f67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies @mpodwysocki's clean-up code for the whole repo to reduce diffs
in snippets pull requests.
NO_CI