Add support for Microsoft.App #4517
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
super-harsh
requested review from
davefellows,
theunrepentantgeek,
matthchr and
babbageclunk
as code owners
theunrepentantgeek
requested changes
Jan 19, 2025
|
|
||
| | Resource | ARM Version | CRD Version | Supported From | Sample | | ||
| |--------------------|-------------|---------------|----------------|--------------------------------------------------------------------------------------------------------------------------------------| | ||
| | ManagedEnvironment | 2024-03-01 | v1api20240301 | 2.12.0 | [View](https://github.com/Azure/azure-service-operator/tree/main/v2/samples/app/v1api20240301/v1api20240301_managedenvironment.yaml) | |
There was a problem hiding this comment.
How come this shows as released, when v2.12.0 is still in development?
v2/azure-arm.yaml
Outdated
| $isSecret: false | ||
| ManagedEnvironment: | ||
| $export: true | ||
| $supportedFrom: 2.12.0 |
There was a problem hiding this comment.
I think this missing v is why it shows up as already released.
Suggested change
| $supportedFrom: 2.12.0 | |
| $supportedFrom: v2.12.0 |
There was a problem hiding this comment.
Good catch! I've made changes above and regenerated the documentation.
| - maximumCount: 2 | ||
| minimumCount: 1 | ||
| name: profile1 | ||
| workloadProfileType: D4 |
There was a problem hiding this comment.
Missing EoLn at the end of each of these samples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds support for Microsoft.App resources below:
How does this PR make you feel?
Checklist