-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create msi for windows #2819
base: main
Are you sure you want to change the base?
Create msi for windows #2819
Conversation
release-pipeline.yml
Outdated
artifactName: 'azCopy-binaries' | ||
displayName: 'Publish binaries' | ||
condition: succeededOrFailed() | ||
# variables: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we undo this commentting here?
@@ -0,0 +1,22 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> | |||
<Wix xmlns="http://schemas.microsoft.com/wix/2006/wi"> | |||
<Product Id="*" Name="azcopy" Language="1033" Version="10.26.0" Manufacturer="Microsoft" UpgradeCode="abeee33a-0cca-4060-89d7-0687f7374f7a"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this version need to change every release? If so, we should add a section to the release process to double check this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes this is the PR in progress not ready for review. Yes will not be using the Version as static value. Will make the changes for it
@@ -0,0 +1,72 @@ | |||
parameters: | |||
working_dir: '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
working_dir: '' | |
- name: working_dir | |
type: string |
nit. Similar changes for the other params,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made a few comments
…into dphulkar/wingetPackage
…into dphulkar/wingetPackage
…into dphulkar/wingetPackage
…into dphulkar/wingetPackage
No description provided.