Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to LMT on missing source hash #2866

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

gapra-msft
Copy link
Member

Description

  • Feature / Bug Fix: (Brief description of the feature or issue being addressed)
    For sync, when source hash is missing, AzCopy should fall back to LMT comparison instead of skipping the file.
    AzCopy sync --compare-hash should fall back to LMT if MD5 not present on source and destination

  • Related Links:

  • Issues

  • Team thread

  • Documents

  • [Email Subject]

Type of Change

  • Bug fix
  • New feature
  • Documentation update required
  • Code quality improvement
  • Other (describe):

How Has This Been Tested?

I have added an e2e test that should cover all scenarios for source hash

  1. hash present and equal
  2. hash present and not equal
  3. hash missing and source LMTafter destination
  4. hash missing and source LMT before destination
    Please see the comments in the test for more info

Thank you for your contribution to AzCopy!

@dphulkar-msft
Copy link
Collaborator

LGTM. However, one end-to-end test is failing, and the pull request requires a code sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants