Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for File Share Limit Reached Error #2892

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix for File Share Limit Reached Error #2892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8388a44
fixed panics, added description for file share full error
wonwuakpa-msft Dec 13, 2024
77fa0ea
Merge branch 'main' into full-fileshare
wonwuakpa-msft Dec 13, 2024
826b35f
linting fix
wonwuakpa-msft Dec 13, 2024
a2f5b65
Merge branch 'full-fileshare' of https://github.com/Azure/azure-stora…
wonwuakpa-msft Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/make.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,6 @@ func init() {
},
}

makeCmd.PersistentFlags().Uint32Var(&rawArgs.quota, "quota-gb", 0, "Specifies the maximum size of the share in gigabytes (GiB), 0 means you accept the file service's default quota.")
makeCmd.PersistentFlags().Uint32Var(&rawArgs.quota, "quota-gb", 0, "Specifies the maximum size of the share in gigabytes (GiB), 0 means you accept the file service's default quota. If `ShareSizeLimitReached` error is hit, increase quota and call resume command.")
rootCmd.AddCommand(makeCmd)
}
6 changes: 4 additions & 2 deletions ste/jobStatusManager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,10 +134,12 @@ func (jm *jobMgr) handleStatusUpdateMessage() {
case msg, ok := <-jstm.xferDone:
if !ok { // Channel is closed, all transfers have been attended.
jstm.xferDone = nil

// close drainXferDone so that other components can know no further updates happen
allXferDoneHandled = true
close(jstm.xferDoneDrained)
if jstm.xferDoneDrained != nil {
close(jstm.xferDoneDrained)
jstm.xferDoneDrained = nil
}
continue
}

Expand Down
1 change: 1 addition & 0 deletions ste/mgr-JobMgr.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,6 +717,7 @@ func (jm *jobMgr) reportJobPartDoneHandler() {
// Inform StatusManager that all parts are done.
if jm.jstm.xferDone != nil {
close(jm.jstm.xferDone)
jm.jstm.xferDone = nil
}

// Wait for all XferDone messages to be processed by statusManager. Front end
Expand Down
Loading