-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File I/O Abstraction Part 8: Simplify module registry related components #16329
Conversation
Test this change out locally with the following install scripts (Action run 13149651171) VSCode
Azure CLI
|
Dotnet Test Results 78 files - 39 78 suites - 39 33m 47s ⏱️ - 17m 20s Results for commit 0e67524. ± Comparison against base commit 5f03b3b. This pull request removes 1785 and adds 618 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the main blockers in replacing
Uri
andIFileResolver
withIFileHandle
is the complexity of the module registry related code. This PR simplifies it by having ArtifactReference hold a reference to BicepSourceFile, eliminating the need forUri
,IConfigurationManager
, andIFeatureProviderFactory
operations when parsing module and extension references.Although this PR includes many file changes, most are unavoidable test updates. The primary modifications are in
Bicep.Core/Registry
.Microsoft Reviewers: Open in CodeFlow