Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 15396 #16330

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Fix for issue 15396 #16330

merged 2 commits into from
Feb 5, 2025

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Feb 5, 2025

Closes #15396

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Test this change out locally with the following install scripts (Action run 13156083273)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 13156083273
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 13156083273"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 13156083273
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 13156083273"

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Dotnet Test Results

    78 files   -     39      78 suites   - 39   33m 59s ⏱️ - 14m 16s
11 730 tests  -     12  11 730 ✅  -     12  0 💤 ±0  0 ❌ ±0 
27 218 runs   - 13 601  27 218 ✅  - 13 601  0 💤 ±0  0 ❌ ±0 

Results for commit cd4f100. ± Comparison against base commit a90dc1f.

This pull request removes 1793 and adds 612 tests. Note that renamed tests count towards both.

		nestedProp1: 1
		nestedProp2: 2
		prop1: true
		prop2: false
	1
	2
	\$'")
	prop1: true
	prop2: false
…
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000
��M\u000b�0\u0018\u0007��\u0014�\u000f0�>
<\u0004\u001d2��k�\u001cd��\u001a\u0008}��!�(]Ԃ�;n\u000f����A�N7+�SSV�p�}\u0004��-�y�z�p\u0005�z�\u0000+�\u0019\u0000�\u0019��\u000e��֥me��~\u0010
����DD�@	\u001a�\u0010\u0011\u0019P������H\u0008o�>GY��\u0006]�kі�}�߾������=ѧ�cʁ�\u0001�\u0016\u0011�\u0014�R�6��d�����������z�M�9�\u0013��=9��8�{\u0002ʪ��\u0000\u000c\u0000\u0000,"'7' is an invalid end of a number. Expected a delimiter. Path: $.INVALID_JSON | LineNumber: 0 | BytePositionInLine: 20.")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000
���
�@\u0014\u0006�Y�\u0014�\u000f0�ѹh�MЦ\u0007��DF���\u0010�{�"�(m�\u0004ͷ��gF~�ޛv�&Ūf\\u0000�\u0019\u0019\u001bXJ���\u000e�3�߀��\u0002\u0008�����׍��*s|�\u0007���&�1�:\u0008��#\u00191\u001e�\u0010�ʎ��\u0011�hi�s�\u0015)��Rߊ.�\u000f����3��\u0007�{�o����_hiC\iM@Ie�t�N�y�\u001f�;\u0014ؖ�4��0?b�m��\k|.���8�3�\u0017Ϋ\u0001�\u0000\u000c\u0000\u0000,"Value cannot be null. (Parameter 'source')")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000
���\u000e�0\u0010\u0006��}
��̔�\u0003\u0007�\u001e}�FI\B1,����\u000e\u0007\u0013\u000f\u0010/\u0008&��uK��/�뷅;\u0014u#Q\u0003�R�
��z���\u0006\u0005�\u000b\u0008 �X!�~�JFtM�j.e��~�J#מ�"GJR2*3\u0019�\u0003k�N7<��\u001c����c����n^���\u000f\u000bʩ\u0005k\u001f4\u0018��~ߺ�O�\u0007P\u00025\u0019������-��"�����\u001fkW\u0010\u0004A\u0010��	pg=}\u0000\u000c\u0000\u0000,"The path: index.json was not found in artifact contents")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000\u0003�Խ
�0\u0010\u0007��>E�\u0003Ĥ�5���Ep�\u0001b{b���V(��n:�K�K?\u0004�\u001bs\u0007w!���{�nѤX�,�\�\u0019\u0019\u001b�B){�;B*"�\u001b'\\u0001\u0000!�\u001d}�\u001e��1�]e�Y?���4Y��P�V�k\u0015�H���bek�PMD�4�9Ί\u0014[v�oEמ\u000f�/}Mg������-�<���\u0001`�\u0004�$<\u0004\u0008m�g����A�C�m�I��\u000e�#Vކ�̵��һ9��8�y\u0001�ߌ�\u0000\u000c\u0000\u0000,"Value cannot be null. (Parameter 'source')")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000\u0003�Խ\u000e�0\u0010\u0007��>\u0005OP�h�����+4J�G(\u0006J$1��e0q�� �����r�4��tg�mi\u000fe�J��S)�\u0006A����\u0000
�\u0017\u0010@ƀ\u0010I?�$#���&��D�\u001f�qb��*\u000b$�d2&%�\u0019\u0001�M��O�ar��Xt��ꛓ�vCA5U��E�Q����\u001e��\u000f�	�d�!4�/\u0000B���/��?�����\u0004Q\u0014E�\u001a�\u0000O\u000e5\u0000\u000c\u0000\u0000,"The path: index.json was not found in artifact contents")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000\u0003��A\u000b�0\u0014\u0007��\u0014�\u0007��n{+�\u0010t�\u0008\u000b��1r��\u0016j ��DtQ��\u0005�w�\u001e�7��ao��V�.J\u001c0"=��F\u000c�X�y�2@\u0014^\u0008"�9Gȩ{��ŭ�TaF\u0019��\u000f\uda56\udcea4�!�@\u0002�%\u0008,e@\u0000���\u001d���Թ��\u0014�y�k|./yS�u����V���
��S��ϐ�\u0001�\u0014Q�\u0019"��Q2�����Q�����a�����1\u001b��3Y�eY�{\u0000r|�?\u0000\u000c\u0000\u0000,"'7' is an invalid end of a number. Expected a delimiter. Path: $.INVALID_JSON | LineNumber: 0 | BytePositionInLine: 20.")
Bicep.Core.IntegrationTests.DecompilationTests ‑ Decompiler_handles_banned_function_replacement ("createArray(1, 2, 3)","array","[
  1
  2
  3
]")
Bicep.Core.IntegrationTests.DecompilationTests ‑ Decompiler_handles_banned_function_replacement ("createObject('key', 'value')","object","{
  key: 'value'
}")
Bicep.Core.IntegrationTests.DecompilationTests ‑ Decompiler_handles_strings_with_newlines ("
","\n")
Bicep.Core.IntegrationTests.DecompilationTests ‑ Decompiler_handles_strings_with_newlines ("
","\r\n")
…

♻️ This comment has been updated with latest results.

@anthony-c-martin anthony-c-martin changed the title Fox for issue 15396 Fix for issue 15396 Feb 5, 2025
@anthony-c-martin anthony-c-martin enabled auto-merge (squash) February 5, 2025 10:51
@anthony-c-martin anthony-c-martin merged commit 93c5975 into main Feb 5, 2025
47 checks passed
@anthony-c-martin anthony-c-martin deleted the ant/issue15396 branch February 5, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import aliases from bicepconfig.json are not used in JSON generation
2 participants