Skip to content
This repository has been archived by the owner on Jul 26, 2024. It is now read-only.

Add resource map_accounts to landingzone.tf #493

Merged
merged 13 commits into from
Sep 18, 2023
Merged

Add resource map_accounts to landingzone.tf #493

merged 13 commits into from
Sep 18, 2023

Conversation

leethanh2112
Copy link
Contributor

@leethanh2112 leethanh2112 commented Aug 22, 2023 •
edited
Loading

Issue-id

PR Checklist

Update configuration for resource map_accounts with caf_solution on branch "int-5.7.0"

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

  • YES
  • NO

Testing

@leethanh2112
Copy link
Contributor Author

@microsoft-github-policy-service agree

@leethanh2112 leethanh2112 mentioned this pull request Aug 22, 2023
Open
@leethanh2112
Copy link
Contributor Author

@microsoft-github-policy-service agree

LaurentLesle
LaurentLesle approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@LaurentLesle LaurentLesle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

leethanh2112
leethanh2112 commented Sep 7, 2023
View reviewed changes
Copy link
Contributor Author

@leethanh2112 leethanh2112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything is good

@leethanh2112
Copy link
Contributor Author

Hi @arnaudlh , Can you help to trigger the pipeline for PR, @LaurentLesle also approved this.

arnaudlh
arnaudlh suggested changes Sep 13, 2023
View reviewed changes
Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR @leethanh2112 please review and commit the changes and we should be GTG!

caf_solution/local.maps.tf Outdated Show resolved Hide resolved
caf_solution/variables.maps.tf Outdated Show resolved Hide resolved
@arnaudlh arnaudlh added the enhancement New feature or request label Sep 13, 2023
@arnaudlh arnaudlh self-requested a review September 18, 2023 01:12
@arnaudlh arnaudlh merged commit 9100bad into Azure:main Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arnaudlh arnaudlh arnaudlh approved these changes

@LaurentLesle LaurentLesle LaurentLesle approved these changes

Assignees

@leethanh2112 leethanh2112

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leethanh2112 @LaurentLesle @arnaudlh