Skip to content

Commit

Permalink
AppInsights input emits metadata
Browse files Browse the repository at this point in the history
  • Loading branch information
@karolz-ms
karolz-ms committed Dec 3, 2018
1 parent 2e3468c commit 72693e7
Show file tree
Hide file tree
Showing 2 changed files with 48 additions and 9 deletions.
55 changes: 47 additions & 8 deletions ...Microsoft.Diagnostics.EventFlow.Inputs.ApplicationInsights/EventFlowTelemetryProcessor.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
using Microsoft.ApplicationInsights.Extensibility;
using Validation;
using Microsoft.Diagnostics.EventFlow.Inputs;
using Microsoft.Diagnostics.EventFlow.Metadata;

namespace Microsoft.Diagnostics.EventFlow.ApplicationInsights
{
Expand Down Expand Up @@ -74,7 +75,7 @@ public void Process(ITelemetry item)
{
var request = item as RequestTelemetry;
eventData.Level = LogLevel.Informational;
AddRequestProperties(eventPayload, request);
AddRequestProperties(eventData, request);
AddMetricValues(eventData, request.Metrics);
}
else if (item is TraceTelemetry)
Expand All @@ -101,14 +102,14 @@ public void Process(ITelemetry item)
{
var dependencyCall = item as DependencyTelemetry;
eventData.Level = LogLevel.Informational;
AddDependencyProperties(eventPayload, dependencyCall);
AddDependencyProperties(eventData, dependencyCall);
AddMetricValues(eventData, dependencyCall.Metrics);
}
else if (item is MetricTelemetry)
{
var metric = item as MetricTelemetry;
eventData.Level = LogLevel.Informational;
AddMetricProperties(eventPayload, metric);
AddMetricProperties(eventData, metric);
}
else if (item is ExceptionTelemetry)
{
Expand All @@ -121,7 +122,7 @@ public void Process(ITelemetry item)
{
eventData.Level = LogLevel.Warning;
}
AddExceptionProperties(eventPayload, exception);
AddExceptionProperties(eventData, exception);
AddMetricValues(eventData, exception.Metrics);
}
else if (item is PageViewTelemetry)
Expand Down Expand Up @@ -283,22 +284,34 @@ private void AddContextProperties(EventData eventData, TelemetryContext context)
}
}

private void AddRequestProperties(IDictionary<string, object> eventPayload, RequestTelemetry request)
private void AddRequestProperties(EventData eventData, RequestTelemetry request)
{
IDictionary<string, object> eventPayload = eventData.Payload;
var requestMetadata = new EventMetadata(RequestData.RequestMetadataKind);
eventData.SetMetadata(requestMetadata);

eventPayload.Add(TelemetryTypeProperty, "request");

eventPayload.Add(nameof(request.Name), request.Name);
requestMetadata.Properties.Add(RequestData.RequestNamePropertyMoniker, nameof(request.Name));

eventPayload.Add(nameof(request.Duration), request.Duration);
requestMetadata.Properties.Add(RequestData.DurationPropertyMoniker, nameof(request.Duration));
requestMetadata.Properties.Add(RequestData.DurationUnitMoniker, nameof(TimeSpan));

if (!string.IsNullOrEmpty(request.Id))
{
eventPayload.Add(nameof(request.Id), request.Id);
}
if (!string.IsNullOrEmpty(request.ResponseCode))
{
eventPayload.Add(nameof(request.ResponseCode), request.ResponseCode);
requestMetadata.Properties.Add(RequestData.ResponseCodePropertyMoniker, nameof(request.ResponseCode));
}
if (request.Success.HasValue)
{
eventPayload.Add(nameof(request.Success), request.Success.Value);
requestMetadata.Properties.Add(RequestData.IsSuccessPropertyMoniker, nameof(request.Success));
}
if (request.Url != null)
{
Expand All @@ -322,25 +335,35 @@ private void AddEventProperties(IDictionary<string, object> eventPayload, EventT
eventPayload.Add(nameof(evt.Name), evt.Name);
}

private void AddDependencyProperties(IDictionary<string, object> eventPayload, DependencyTelemetry dependencyCall)
private void AddDependencyProperties(EventData eventData, DependencyTelemetry dependencyCall)
{
IDictionary<string, object> eventPayload = eventData.Payload;
var dependencyMetadata = new EventMetadata(DependencyData.DependencyMetadataKind);
eventData.SetMetadata(dependencyMetadata);

eventPayload.Add(TelemetryTypeProperty, "dependency");
eventPayload.Add(nameof(dependencyCall.Name), dependencyCall.Name);

if (dependencyCall.Success.HasValue)
{
eventPayload.Add(nameof(dependencyCall.Success), dependencyCall.Success.Value);
dependencyMetadata.Properties.Add(DependencyData.IsSuccessPropertyMoniker, nameof(dependencyCall.Success));
}
if (dependencyCall.Duration != TimeSpan.Zero)
{
eventPayload.Add(nameof(dependencyCall.Duration), dependencyCall.Duration);
dependencyMetadata.Properties.Add(DependencyData.DurationPropertyMoniker, nameof(dependencyCall.Duration));
dependencyMetadata.Properties.Add(DependencyData.DurationUnitMoniker, nameof(TimeSpan));
}
if (!string.IsNullOrEmpty(dependencyCall.Type))
{
eventPayload.Add(nameof(dependencyCall.Type), dependencyCall.Type);
dependencyMetadata.Properties.Add(DependencyData.DependecyTypeMoniker, dependencyCall.Type);
}
if (!string.IsNullOrEmpty(dependencyCall.Target))
{
eventPayload.Add(nameof(dependencyCall.Target), dependencyCall.Target);
dependencyMetadata.Properties.Add(DependencyData.TargetPropertyMoniker, nameof(dependencyCall.Target));
}
if (!string.IsNullOrEmpty(dependencyCall.Data))
{
Expand All @@ -349,18 +372,28 @@ private void AddDependencyProperties(IDictionary<string, object> eventPayload, D
if (!string.IsNullOrEmpty(dependencyCall.ResultCode))
{
eventPayload.Add(nameof(dependencyCall.ResultCode), dependencyCall.ResultCode);
dependencyMetadata.Properties.Add(DependencyData.ResponseCodePropertyMoniker, nameof(dependencyCall.ResultCode));
}
if (!string.IsNullOrEmpty(dependencyCall.Id))
{
eventPayload.Add(nameof(dependencyCall.Id), dependencyCall.Id);
}
}

private void AddMetricProperties(IDictionary<string, object> eventPayload, MetricTelemetry metric)
private void AddMetricProperties(EventData eventData, MetricTelemetry metric)
{
IDictionary<string, object> eventPayload = eventData.Payload;
var metricMetadata = new EventMetadata(MetricData.MetricMetadataKind);
eventData.SetMetadata(metricMetadata);

eventPayload.Add(TelemetryTypeProperty, "metric");

eventPayload.Add(nameof(metric.Name), metric.Name);
metricMetadata.Properties.Add(MetricData.MetricNamePropertyMoniker, nameof(metric.Name));

eventPayload.Add(nameof(metric.Sum), metric.Sum);
metricMetadata.Properties.Add(MetricData.MetricValuePropertyMoniker, nameof(metric.Sum));

if (metric.Count.HasValue)
{
eventPayload.Add(nameof(metric.Count), metric.Count.Value);
Expand All @@ -379,10 +412,16 @@ private void AddMetricProperties(IDictionary<string, object> eventPayload, Metri
}
}

private void AddExceptionProperties(IDictionary<string, object> eventPayload, ExceptionTelemetry exception)
private void AddExceptionProperties(EventData eventData, ExceptionTelemetry exception)
{
IDictionary<string, object> eventPayload = eventData.Payload;
var exceptionMetadata = new EventMetadata(ExceptionData.ExceptionMetadataKind);
eventData.SetMetadata(exceptionMetadata);

eventPayload.Add(TelemetryTypeProperty, "exception");
eventPayload.Add(nameof(exception.Exception), exception.Exception.ToString());
exceptionMetadata.Properties.Add(ExceptionData.ExceptionPropertyMoniker, nameof(exception.Exception));

if (!string.IsNullOrEmpty(exception.Message))
{
eventPayload.Add(nameof(exception.Message), exception.Message);
Expand Down
2 changes: 1 addition & 1 deletion ...uts.ApplicationInsights/Microsoft.Diagnostics.EventFlow.Inputs.ApplicationInsights.csproj
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<Description>Provides an implementation of Application Insights telemetry processor that feeds Application Insights telemetry into EventFlow pipeline.
This allows sending diagnostics data from applications instrumented with Application Insights to destinations other than Application Insights service.</Description>
<Copyright>© Microsoft Corporation. All rights reserved.</Copyright>
<VersionPrefix>1.4.1</VersionPrefix>
<VersionPrefix>1.4.2</VersionPrefix>
<Authors>Microsoft</Authors>
<TargetFrameworks>netstandard1.6;net451;netstandard2.0</TargetFrameworks>
<AssemblyName>Microsoft.Diagnostics.EventFlow.Inputs.ApplicationInsights</AssemblyName>
Expand Down

0 comments on commit 72693e7

Please sign in to comment.