-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase Azure Storage SDK version and DTFx.AzureStorage ver #1176
Conversation
@@ -12,6 +12,7 @@ | |||
<PackageReference Include="MSTest.TestFramework" Version="3.5.0" /> | |||
<PackageReference Include="Microsoft.Extensions.Logging" Version="6.0.0" /> | |||
<PackageReference Include="Microsoft.Extensions.Logging.Console" Version="6.0.0" /> | |||
<PackageReference Include="System.Text.Json" Version="6.0.10" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add this to pass the test..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix the indentation here? Also, what test wasn't passing without this package reference?
@@ -12,6 +12,7 @@ | |||
<PackageReference Include="MSTest.TestFramework" Version="3.5.0" /> | |||
<PackageReference Include="Microsoft.Extensions.Logging" Version="6.0.0" /> | |||
<PackageReference Include="Microsoft.Extensions.Logging.Console" Version="6.0.0" /> | |||
<PackageReference Include="System.Text.Json" Version="6.0.10" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix the indentation here? Also, what test wasn't passing without this package reference?
Just FYI, we're targeting Azure.Core v1.43.0 even though there are newer versions because the newer versions contain a breaking dependency change that causes problems with the current Azure Functions host versions. v1.43.0 is the latest version that works. Once the Functions team has updated the host to support newer versions of Azure.Core, we should update our dependency as well to match. |
as titled.
Azure.Core updated from 1.41.0 to 1.43.0
Azure.Data.Tables updated from 12.8.3 to 12.9.1
Azure.Storage.Blobs updated from 12.20.0 to 12.22.1
Azure.Storage.Queues updated from 12.18.0 to 12.20.0