address comments

Azure · Dec 17, 2024 · 9dc98fe · 9dc98fe
1 parent daea2b4
commit 9dc98fe
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/pkg/controllers/rollout/controller.go b/pkg/controllers/rollout/controller.go
@@ -677,7 +677,7 @@ func handleClusterResourceOverrideSnapshot(o client.Object, q workqueue.RateLimi
 	// check if it is the latest resource resourceBinding
 	isLatest, err := strconv.ParseBool(snapshot.GetLabels()[fleetv1beta1.IsLatestSnapshotLabel])
 	if err != nil {
-		klog.ErrorS(controller.NewUnexpectedBehaviorError(fmt.Errorf("invalid annotation value %s : %w", fleetv1beta1.IsLatestSnapshotLabel, err)),
+		klog.ErrorS(controller.NewUnexpectedBehaviorError(fmt.Errorf("invalid label value %s : %w", fleetv1beta1.IsLatestSnapshotLabel, err)),
 			"Resource clusterResourceOverrideSnapshot has does not have a valid islatest label", "clusterResourceOverrideSnapshot", snapshotKRef)
 		return
 	}
@@ -710,7 +710,7 @@ func handleResourceOverrideSnapshot(o client.Object, q workqueue.RateLimitingInt
 	// check if it is the latest resource resourceBinding
 	isLatest, err := strconv.ParseBool(snapshot.GetLabels()[fleetv1beta1.IsLatestSnapshotLabel])
 	if err != nil {
-		klog.ErrorS(controller.NewUnexpectedBehaviorError(fmt.Errorf("invalid annotation value %s : %w", fleetv1beta1.IsLatestSnapshotLabel, err)),
+		klog.ErrorS(controller.NewUnexpectedBehaviorError(fmt.Errorf("invalid label value %s : %w", fleetv1beta1.IsLatestSnapshotLabel, err)),
 			"Resource resourceOverrideSnapshot has does not have a valid islatest annotation", "resourceOverrideSnapshot", snapshotKRef)
 		return
 	}

diff --git a/test/e2e/placement_cro_test.go b/test/e2e/placement_cro_test.go
@@ -94,7 +94,7 @@ var _ = Describe("creating clusterResourceOverride (selecting all clusters) to o
 		checkIfOverrideAnnotationsOnAllMemberClusters(true, want)
 	})
 
-	It("update cro attached to this CRP only and annotation value", func() {
+	It("update cro attached to this CRP only and change annotation value", func() {
 		Eventually(func() error {
 			cro := &placementv1alpha1.ClusterResourceOverride{}
 			if err := hubClient.Get(ctx, types.NamespacedName{Name: croName}, cro); err != nil {

diff --git a/test/e2e/placement_ro_test.go b/test/e2e/placement_ro_test.go
@@ -98,7 +98,7 @@ var _ = Describe("creating resourceOverride (selecting all clusters) to override
 		checkIfOverrideAnnotationsOnAllMemberClusters(false, want)
 	})
 
-	It("update ro attached to this CRP only and annotation value", func() {
+	It("update ro attached to this CRP only and change annotation value", func() {
 		Eventually(func() error {
 			ro := &placementv1alpha1.ResourceOverride{}
 			if err := hubClient.Get(ctx, types.NamespacedName{Name: roName, Namespace: roNamespace}, ro); err != nil {