Skip to content

Commit

Permalink
fix static error
Browse files Browse the repository at this point in the history
  • Loading branch information
Ryan Zhang committed Feb 1, 2025
1 parent a9ea18c commit ed4ed9d
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions pkg/controllers/rollout/controller_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ var (
}),
}

defaultUnavailablePeriodSeconds = time.Duration(5)
defaultUnavailablePeriod = time.Duration(5)
)

func serviceScheme(t *testing.T) *runtime.Scheme {
Expand Down Expand Up @@ -1125,7 +1125,7 @@ func TestPickBindingsToRoll(t *testing.T) {
},
},
wantNeedRoll: true,
wantWaitTime: defaultUnavailablePeriodSeconds * time.Second,
wantWaitTime: defaultUnavailablePeriod * time.Second,
},
"test one failed to apply bound binding and four failed non ready bound bindings, outdated resources with maxUnavailable specified - rollout allowed": {
allBindings: []*fleetv1beta1.ClusterResourceBinding{
Expand Down Expand Up @@ -1169,7 +1169,7 @@ func TestPickBindingsToRoll(t *testing.T) {
},
},
wantNeedRoll: true,
wantWaitTime: defaultUnavailablePeriodSeconds * time.Second,
wantWaitTime: defaultUnavailablePeriod * time.Second,
},
"test three failed to apply bound binding, two ready bound binding, outdated resources with maxUnavailable specified - rollout allowed": {
allBindings: []*fleetv1beta1.ClusterResourceBinding{
Expand Down Expand Up @@ -1213,7 +1213,7 @@ func TestPickBindingsToRoll(t *testing.T) {
},
},
wantNeedRoll: true,
wantWaitTime: defaultUnavailablePeriodSeconds * time.Second,
wantWaitTime: defaultUnavailablePeriod * time.Second,
},
"test bound ready bindings, maxUnavailable is set to zero - rollout blocked": {
allBindings: []*fleetv1beta1.ClusterResourceBinding{
Expand Down Expand Up @@ -1911,7 +1911,7 @@ func TestPickBindingsToRoll(t *testing.T) {
Type: intstr.Int,
IntVal: 0,
},
UnavailablePeriodSeconds: ptr.To(int(defaultUnavailablePeriodSeconds)),
UnavailablePeriodSeconds: ptr.To(int(defaultUnavailablePeriod)),
}, nil)),
wantDesiredBindingsSpec: []fleetv1beta1.ResourceBindingSpec{
{},
Expand All @@ -1932,7 +1932,7 @@ func TestPickBindingsToRoll(t *testing.T) {
wantTobeUpdatedBindings: []int{4, 5}, // no ready unscheduled bindings, so scheduled bindings were chosen.
wantStaleUnselectedBindings: []int{},
wantNeedRoll: true,
wantWaitTime: defaultUnavailablePeriodSeconds * time.Second,
wantWaitTime: defaultUnavailablePeriod * time.Second,
},
"test downscale with resource snapshot change, evict ready bound binding - rollout allowed for one unscheduled binding": {
allBindings: []*fleetv1beta1.ClusterResourceBinding{
Expand Down Expand Up @@ -2214,7 +2214,7 @@ func generateDefaultRollingUpdateConfig() *fleetv1beta1.RollingUpdateConfig {
Type: intstr.Int,
IntVal: 3,
},
UnavailablePeriodSeconds: ptr.To(int(defaultUnavailablePeriodSeconds)),
UnavailablePeriodSeconds: ptr.To(int(defaultUnavailablePeriod)),
}
}

Expand Down

0 comments on commit ed4ed9d

Please sign in to comment.