feat: add the support for configmap wrapper #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelawyu
reviewed
Oct 7, 2023
michaelawyu
reviewed
Oct 7, 2023
michaelawyu
reviewed
Oct 7, 2023
michaelawyu
reviewed
Oct 7, 2023
michaelawyu
reviewed
Oct 7, 2023
michaelawyu
reviewed
Oct 7, 2023
pkg/controllers/workgenerator/manifests/test-envelop-configmap.yaml
Outdated
Show resolved
Hide resolved
michaelawyu
reviewed
Oct 7, 2023
pkg/controllers/workgenerator/manifests/test-envelop-configmap2.yaml
Outdated
Show resolved
Hide resolved
ryanzhang-oss
changed the title
ryanzhang-oss
force-pushed
the
handleConfigMap
branch
from
ab48640 to
f9bf622
Compare
added 3 commits
October 12, 2023 09:05
ryanzhang-oss
force-pushed
the
handleConfigMap
branch
from
f9bf622 to
6a30c12
Compare
ryanzhang-oss
force-pushed
the
handleConfigMap
branch
from
6a30c12 to
55b2d45
Compare
ryanzhang-oss
force-pushed
the
handleConfigMap
branch
from
a281f69 to
3a1b4a9
Compare
michaelawyu
reviewed
Oct 16, 2023
pkg/controllers/clusterresourceplacement/placement_status_test.go
Outdated
Show resolved
Hide resolved
michaelawyu
reviewed
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
add the support for configmap wrapper
-- we create a separate work object for the wrapper
-- CRP populate the envelope identifier when a wrapped object is not applied successfully
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
UT/IT
Special notes for your reviewer