test: add v1beta1 E2E test cases (3/) #559
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,179 @@ | ||
| /* | ||
| Copyright (c) Microsoft Corporation. | ||
| Licensed under the MIT license. | ||
| */ | ||
|
|
||
| package e2e | ||
|
|
||
| import ( | ||
| "fmt" | ||
|
|
||
| . "github.com/onsi/ginkgo/v2" | ||
| . "github.com/onsi/gomega" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "k8s.io/apimachinery/pkg/types" | ||
| "k8s.io/utils/pointer" | ||
|
|
||
| placementv1beta1 "go.goms.io/fleet/apis/placement/v1beta1" | ||
| "go.goms.io/fleet/test/e2e/framework" | ||
| ) | ||
|
|
||
| var _ = Describe("placing resources using a CRP of PickFixed placement type", func() { | ||
| Context("pick some clusters", Ordered, func() { | ||
| crpName := fmt.Sprintf(crpNameTemplate, GinkgoParallelProcess()) | ||
|
|
||
| BeforeAll(func() { | ||
| // Create the resources. | ||
| createWorkResources() | ||
|
|
||
| // Create the CRP. | ||
| crp := &placementv1beta1.ClusterResourcePlacement{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: crpName, | ||
| // Add a custom finalizer; this would allow us to better observe | ||
| // the behavior of the controllers. | ||
| Finalizers: []string{customDeletionBlockerFinalizer}, | ||
| }, | ||
| Spec: placementv1beta1.ClusterResourcePlacementSpec{ | ||
| ResourceSelectors: workResourceSelector(), | ||
| Strategy: placementv1beta1.RolloutStrategy{ | ||
| Type: placementv1beta1.RollingUpdateRolloutStrategyType, | ||
| RollingUpdate: &placementv1beta1.RollingUpdateConfig{ | ||
| UnavailablePeriodSeconds: pointer.Int(2), | ||
| }, | ||
| }, | ||
| Policy: &placementv1beta1.PlacementPolicy{ | ||
| PlacementType: placementv1beta1.PickFixedPlacementType, | ||
| ClusterNames: []string{ | ||
| memberCluster1Name, | ||
| }, | ||
| }, | ||
| }, | ||
| } | ||
| Expect(hubClient.Create(ctx, crp)).To(Succeed(), "Failed to create CRP") | ||
| }) | ||
|
|
||
| It("should place resources on specified clusters", func() { | ||
| resourcePlacedActual := workNamespaceAndConfigMapPlacedOnClusterActual(memberCluster1) | ||
| Eventually(resourcePlacedActual, eventuallyDuration, eventuallyInterval).Should(Succeed(), "Failed to place resources on specified clusters") | ||
| }) | ||
|
|
||
| It("should update CRP status as expected", func() { | ||
| crpStatusUpdatedActual := crpStatusUpdatedActual(workResourceIdentifiers(), []string{memberCluster1Name}, nil) | ||
| Eventually(crpStatusUpdatedActual, eventuallyDuration, eventuallyInterval).Should(Succeed(), "Failed to update CRP status as expected") | ||
| }) | ||
|
|
||
| AfterAll(func() { | ||
| ensureCRPAndRelatedResourcesDeletion(crpName, []*framework.Cluster{memberCluster1}) | ||
| }) | ||
| }) | ||
|
|
||
| Context("refreshing target clusters", Ordered, func() { | ||
| crpName := fmt.Sprintf(crpNameTemplate, GinkgoParallelProcess()) | ||
|
|
||
| BeforeAll(func() { | ||
| // Create the resources. | ||
| createWorkResources() | ||
|
|
||
| // Create the CRP. | ||
| crp := &placementv1beta1.ClusterResourcePlacement{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: crpName, | ||
| // Add a custom finalizer; this would allow us to better observe | ||
| // the behavior of the controllers. | ||
| Finalizers: []string{customDeletionBlockerFinalizer}, | ||
| }, | ||
| Spec: placementv1beta1.ClusterResourcePlacementSpec{ | ||
| ResourceSelectors: workResourceSelector(), | ||
| Strategy: placementv1beta1.RolloutStrategy{ | ||
| Type: placementv1beta1.RollingUpdateRolloutStrategyType, | ||
| RollingUpdate: &placementv1beta1.RollingUpdateConfig{ | ||
| UnavailablePeriodSeconds: pointer.Int(2), | ||
| }, | ||
| }, | ||
| Policy: &placementv1beta1.PlacementPolicy{ | ||
| PlacementType: placementv1beta1.PickFixedPlacementType, | ||
| ClusterNames: []string{ | ||
| memberCluster1Name, | ||
| }, | ||
| }, | ||
| }, | ||
| } | ||
| Expect(hubClient.Create(ctx, crp)).To(Succeed(), "Failed to create CRP") | ||
|
|
||
| // Verify that resources are placed on specified clusters. | ||
| resourcePlacedActual := workNamespaceAndConfigMapPlacedOnClusterActual(memberCluster1) | ||
| Eventually(resourcePlacedActual, eventuallyDuration, eventuallyInterval).Should(Succeed(), "Failed to place resources on specified clusters") | ||
|
|
||
| // Update the CRP to pick a different cluster. | ||
| Expect(hubClient.Get(ctx, types.NamespacedName{Name: crpName}, crp)).To(Succeed(), "Failed to get CRP") | ||
| crp.Spec.Policy.ClusterNames = []string{memberCluster2Name} | ||
| Expect(hubClient.Update(ctx, crp)).To(Succeed(), "Failed to update CRP") | ||
|
Comment on lines
+107
to
+111
There was a problem hiding this comment. I wonder what logic should be in BeforeAll vs IT? I don't really see a clear pattern. I would get rid of the BeforeAll or only keep it to only the initial setup. |
||
| }) | ||
|
|
||
| It("should place resources on newly specified clusters", func() { | ||
| resourcePlacedActual := workNamespaceAndConfigMapPlacedOnClusterActual(memberCluster2) | ||
| Eventually(resourcePlacedActual, eventuallyDuration, eventuallyInterval).Should(Succeed(), "Failed to place resources on specified clusters") | ||
| }) | ||
|
|
||
| It("should remove resources from previously specified clusters", func() { | ||
| resourceRemovedActual := workNamespaceRemovedFromClusterActual(memberCluster1) | ||
| Eventually(resourceRemovedActual, eventuallyDuration, eventuallyInterval).Should(Succeed(), "Failed to remove resources from previously specified clusters") | ||
| }) | ||
|
|
||
| It("should update CRP status as expected", func() { | ||
| crpStatusUpdatedActual := crpStatusUpdatedActual(workResourceIdentifiers(), []string{memberCluster2Name}, nil) | ||
| Eventually(crpStatusUpdatedActual, eventuallyDuration, eventuallyInterval).Should(Succeed(), "Failed to update CRP status as expected") | ||
| }) | ||
|
Comment on lines
+124
to
+127
There was a problem hiding this comment. I think most user will check the CRP status first |
||
|
|
||
| AfterAll(func() { | ||
| ensureCRPAndRelatedResourcesDeletion(crpName, []*framework.Cluster{memberCluster2}) | ||
| }) | ||
| }) | ||
|
|
||
| Context("pick unhealthy and non-existent clusters", Ordered, func() { | ||
| crpName := fmt.Sprintf(crpNameTemplate, GinkgoParallelProcess()) | ||
|
|
||
| BeforeAll(func() { | ||
| // Create the resources. | ||
| createWorkResources() | ||
|
|
||
| // Create the CRP. | ||
| crp := &placementv1beta1.ClusterResourcePlacement{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: crpName, | ||
| // Add a custom finalizer; this would allow us to better observe | ||
| // the behavior of the controllers. | ||
| Finalizers: []string{customDeletionBlockerFinalizer}, | ||
| }, | ||
| Spec: placementv1beta1.ClusterResourcePlacementSpec{ | ||
| ResourceSelectors: workResourceSelector(), | ||
| Strategy: placementv1beta1.RolloutStrategy{ | ||
| Type: placementv1beta1.RollingUpdateRolloutStrategyType, | ||
| RollingUpdate: &placementv1beta1.RollingUpdateConfig{ | ||
| UnavailablePeriodSeconds: pointer.Int(2), | ||
| }, | ||
| }, | ||
| Policy: &placementv1beta1.PlacementPolicy{ | ||
| PlacementType: placementv1beta1.PickFixedPlacementType, | ||
| ClusterNames: []string{ | ||
| memberCluster4Name, | ||
| memberCluster5Name, | ||
| memberCluster6Name, | ||
|
Comment on lines
+159
to
+162
There was a problem hiding this comment. I guess some of them are unhealthy cluster, it would be great if their name reflect that to improve the test readability. |
||
| }, | ||
| }, | ||
| }, | ||
| } | ||
| Expect(hubClient.Create(ctx, crp)).To(Succeed(), "Failed to create CRP") | ||
| }) | ||
|
|
||
| It("should update CRP status as expected", func() { | ||
| crpStatusUpdatedActual := crpStatusUpdatedActual(workResourceIdentifiers(), nil, []string{memberCluster4Name, memberCluster5Name, memberCluster6Name}) | ||
| Eventually(crpStatusUpdatedActual, eventuallyDuration, eventuallyInterval).Should(Succeed(), "Failed to update CRP status as expected") | ||
| }) | ||
|
|
||
| AfterAll(func() { | ||
| ensureCRPAndRelatedResourcesDeletion(crpName, []*framework.Cluster{}) | ||
| }) | ||
| }) | ||
| }) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the check order should be reversed