feat: guard rail for v1beta1 MC #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arvindthiru
force-pushed
the
guardRailv1betaMC
branch
from
5769d1d to
7039eff
Compare
|
I'm not sure why this run failed exactly but wanted to bring it up before merging the PR https://github.com/Azure/fleet/actions/runs/6537345902/job/17750988112 After offline sync: seems like a very rare case not sure of the root cause yet, have not been able to replicate it again |
Arvindthiru
force-pushed
the
guardRailv1betaMC
branch
2 times, most recently
from
efeefef to
20d0b0c
Compare
michaelawyu
reviewed
Oct 17, 2023
michaelawyu
reviewed
Oct 17, 2023
michaelawyu
reviewed
Oct 17, 2023
michaelawyu
reviewed
Oct 17, 2023
Arvindthiru
force-pushed
the
guardRailv1betaMC
branch
from
1104a4a to
b9abb93
Compare
ryanzhang-oss
approved these changes
Oct 19, 2023
Comment on lines
+30
to
+33
| var ( | ||
| mcGVK = metav1.GroupVersionKind{Group: clusterv1beta1.GroupVersion.Group, Version: clusterv1beta1.GroupVersion.Version, Kind: "MemberCluster"} | ||
| resourceDeniedFormat = "user: %s in groups: %v is not allowed to %s resource %+v/%s: %+v" | ||
| ) |
There was a problem hiding this comment.
why add those in a file that does not use them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer