fix: update policy snapshot status in cases where only the observed CRP generation changes #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -704,18 +711,16 @@ func (f *framework) updatePolicySnapshotStatusFromBindings( | |||
| // Compare the new decisions + condition with the old ones. | |||
| currentDecisions := policy.Status.ClusterDecisions | |||
| currentCondition := meta.FindStatusCondition(policy.Status.Conditions, string(placementv1beta1.PolicySnapshotScheduled)) | |||
| if equalDecisions(currentDecisions, newDecisions) && condition.EqualCondition(currentCondition, &newCondition) { | |||
| if observedCRPGeneration == policy.Status.ObservedCRPGeneration && | |||
There was a problem hiding this comment.
when will we hit the case that the decision/condition doesn't change but the CRP's generation has changed (selector changed)
ryanzhang-oss
approved these changes
Oct 19, 2023
zhiying-lin
pushed a commit
to zhiying-lin/fleet
that referenced
this pull request
Oct 20, 2023
This reverts commit 1c90db0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR fixes an issue where policy snapshot status will not be updated when the scheduling policy itself does not change, yet the CRP generation is incremented (i.e., resource only change).
It also added a unit test that is not checked in in prev. PRs.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer