feat: v1beta1 IMC, Work guard rail #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arvindthiru
force-pushed
the
guardRailv1beta1IMC
branch
from
8c02e43 to
4169e93
Compare
Arvindthiru
changed the title
Arvindthiru
force-pushed
the
guardRailv1beta1IMC
branch
from
0824290 to
cb34952
Compare
pkg/webhook/fleetresourcehandler/fleetresourcehandler_webhook.go
Outdated
Show resolved
Hide resolved
| response = v.handleFleetMemberNamespacedResource(ctx, req) | ||
| case req.Kind == eventGVK: | ||
| klog.V(2).InfoS("handling event resource", "GVK", eventGVK, "namespacedName", namespacedName, "operation", req.Operation, "subResource", req.SubResource) | ||
| response = v.handleEvent(ctx, req) | ||
| case req.Namespace != "": | ||
| klog.V(2).InfoS(fmt.Sprintf("handling %s resource", req.Kind.Kind), "GVK", req.Kind, "namespacedName", namespacedName, "operation", req.Operation, "subResource", req.SubResource) | ||
| klog.V(2).InfoS(fmt.Sprintf(handleResourceFmt, req.RequestKind.Kind), "GVK", req.RequestKind, "namespacedName", namespacedName, "operation", req.Operation, "subResource", req.SubResource) |
There was a problem hiding this comment.
why use requestKind instead of Kind?
There was a problem hiding this comment.
RequestKind is the kind associated to the object in the original request, since it the source truth decided to use that
There was a problem hiding this comment.
RequestKind and Kind both use metav1.GroupVersionKind
Arvindthiru
force-pushed
the
guardRailv1beta1IMC
branch
from
08fb1b2 to
3eb21b8
Compare
ryanzhang-oss
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer