Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaky fleet guard rail E2E where namespace is terminating #586

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

Arvindthiru
Copy link
Contributor

@Arvindthiru Arvindthiru commented Nov 1, 2023

Description of your changes

Fixes #

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Special notes for your reviewer

@Arvindthiru Arvindthiru changed the title [fix] flaky fleet guard rail E2Es fix: flaky fleet guard rail E2Es Nov 1, 2023
@Arvindthiru
Copy link
Contributor Author

Arvindthiru commented Nov 2, 2023

The fleet guard rail tests technically cannot be run in parallel because the current E2E setup runs the tests in parallel, but it only uses two processes (Github action constraint) meaning the member clusters that get created are either named mc-1 or mc-2. So, when these tests are run in parallel there are bound to be cases where two describe blocks in the fleet guard rail E2E end up using the same name for member cluster like mc-1 so we have run these tests in Serial mode mentioned here https://onsi.github.io/ginkgo/#serial-specs by specifying as Serial these Specs are never run in parallel with other specs

#580 sets all the describe blocks to be Serial and Ordered to avoid conflicts and it should fix flakes like this,
image

#580 should be merged before this PR as this is a follow up.

This PR fixes the flake mentioned in the screenshot down below,
image
Where a member cluster namespace is in terminating state, but resources are being created on the same namespace which tells us that two Describe container are being run in parallel with the same GinkgoParallelProcess()

The changes in the PR ensures that the namespace no longer exists in the AfterAll block before it exits.

@Arvindthiru Arvindthiru marked this pull request as ready for review November 2, 2023 06:27
@Arvindthiru Arvindthiru changed the title fix: flaky fleet guard rail E2Es fix: flaky fleet guard rail E2E where namespace is terminating Nov 2, 2023
@Arvindthiru Arvindthiru merged commit 1c61d4c into Azure:main Nov 3, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants