feat: add resource snapshot info in the crp status #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiying-lin
changed the title
zhiying-lin
changed the title
zhiying-lin
changed the title
circy9
reviewed
Nov 2, 2023
| @@ -340,6 +340,11 @@ type ClusterResourcePlacementStatus struct { | |||
| // +optional | |||
| SelectedResources []ResourceIdentifier `json:"selectedResources,omitempty"` | |||
|
|
|||
| // ClusterResourceSnapshots is a list of clusterResourceSnapshot names. | |||
There was a problem hiding this comment.
Does this only contain the most recent resource snapshots or all existing resource snapshots for this placement?
There was a problem hiding this comment.
I assume this only contains the current resource snapshots.
There was a problem hiding this comment.
If so, be explicit in the comment.
circy9
reviewed
Nov 2, 2023
| @@ -340,6 +340,11 @@ type ClusterResourcePlacementStatus struct { | |||
| // +optional | |||
| SelectedResources []ResourceIdentifier `json:"selectedResources,omitempty"` | |||
|
|
|||
| // ClusterResourceSnapshots is a list of clusterResourceSnapshot names. | |||
There was a problem hiding this comment.
I assume this only contains the current resource snapshots.
| // ClusterResourceSnapshots is a list of clusterResourceSnapshot names. | ||
| // ClusterResourceSnapshot is used to store a snapshot of selected resources by a resource placement policy. | ||
| // A placement could produce multiple clusterResourceSnapshots to select large amount of resources. | ||
| ClusterResourceSnapshots []string `json:"clusterResourceSnapshots,omitempty"` |
There was a problem hiding this comment.
Does the PlacementStatuses reflect the status of the listed ClusterResourceSnapshots or they can correspond to a previous version of the snapshots?
Basically, will we produce 2?
- snapshot1, placementstatus for snapshot1
- snapshot2, placementstatus for snapshot1
- snapshot2, placementstatus for snapshot2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Provide a way to show the resource content applied by CRP.
Note, the clusterResourceSnapshot objects will become a customer visible object and customer can check the resource content by looking at the CRP status.
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
API change
Special notes for your reviewer