fix: add log for untolerated taint #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwtty
approved these changes
Oct 21, 2024
| @@ -26,6 +27,8 @@ func (p *Plugin) Filter( | |||
| if !isUntolerated { | |||
| return nil | |||
| } | |||
| policyRef := klog.KObj(policy) | |||
There was a problem hiding this comment.
this is not reused, why create this var?
| @@ -26,6 +27,8 @@ func (p *Plugin) Filter( | |||
| if !isUntolerated { | |||
| return nil | |||
| } | |||
| policyRef := klog.KObj(policy) | |||
| klog.V(2).InfoS("Cluster is unschedulable, because taint cannot be tolerated", "clusterSchedulingPolicySnapshot", policyRef, "taint", taint) | |||
There was a problem hiding this comment.
I looked at the other plugins, I don't see logs there, is there any reason? Should we log more in each plug-in?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer