feat: emit the cluster profile objects #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanzhang-oss
force-pushed
the
cluster-profile
branch
2 times, most recently
from
4ebf5ea to
b9aa442
Compare
zhiying-lin
reviewed
Nov 8, 2024
zhiying-lin
reviewed
Nov 8, 2024
michaelawyu
reviewed
Nov 8, 2024
pkg/controllers/clusterinventory/clusterprofile/controller_integration_test.go
Outdated
Show resolved
Hide resolved
pkg/controllers/clusterinventory/clusterprofile/controller_integration_test.go
Outdated
Show resolved
Hide resolved
| ) | ||
|
|
||
| // This container cannot be run in parallel with other ITs because it uses a shared fakePlacementController. | ||
| var _ = Describe("Test ClusterProfile Controller", func() { |
There was a problem hiding this comment.
Hi Ryan! A nit: I understand that currently there are no other integration tests, but maybe we should mark it as Serial already?
There was a problem hiding this comment.
will this suite interfere with other integration tests?
There was a problem hiding this comment.
Ah, the comment (line 33) mentions so; I assume it's because of the member cluster creation?
There was a problem hiding this comment.
oh, the comment is wrong
| if condition == nil { | ||
| t.Fatalf("expected condition to be set, but it was not") | ||
| } | ||
| if condition.Status != tt.expectedConditionStatus { |
There was a problem hiding this comment.
Hi Ryan! It might be easier to use the cmp package?
There was a problem hiding this comment.
will open another PR
ryanzhang-oss
force-pushed
the
cluster-profile
branch
from
3c0541d to
0509ae6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #467
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer