feat: improve gpu-provisioner based on sigs.k8s.io/karpenter #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rambohe-ch
commented
Dec 8, 2024
rambohe-ch
commented
- upgrade CRD: Machine to NodeClaim
- update aws/karpenter-core to sigs.k8s.io/karpenter
- add webhook for v1beta1.NodeClaim and v1.NodeClaim conversion
- add instance garbage collection controller for cleanuping leaked cloud provider instance and node.
- remove unused files like sku, pricing, instancetype, etc.
- improve nodeclaim launch error cases: if the return error is InvalidParameterError, LocationRestrictionError or InsufficientCapacityError, [nodeclaim launch] controller will publish a warning event, then delete the nodeclaim because of these errors are not recoverable, so it is not necessary to retry create agentpool.
- add unit test cases
rambohe-ch
requested review from
Fei-Guo,
helayoty and
ishaansehgal99
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #185 +/- ##
===========================================
+ Coverage 57.26% 71.26% +13.99%
===========================================
Files 5 4 -1
Lines 454 435 -19
===========================================
+ Hits 260 310 +50
+ Misses 185 107 -78
- Partials 9 18 +9 ☔ View full report in Codecov by Sentry. |
rambohe-ch
force-pushed
the
upgrade-to-node-claim
branch
from
7f97f84 to
3304c0b
Compare
rambohe-ch
force-pushed
the
upgrade-to-node-claim
branch
from
3304c0b to
da1b0a0
Compare
rambohe-ch
force-pushed
the
upgrade-to-node-claim
branch
from
da1b0a0 to
27b96e1
Compare
rambohe-ch
force-pushed
the
upgrade-to-node-claim
branch
from
27b96e1 to
5f2d0cc
Compare
rambohe-ch
force-pushed
the
upgrade-to-node-claim
branch
from
5f2d0cc to
6f10082
Compare
rambohe-ch
force-pushed
the
upgrade-to-node-claim
branch
from
6f10082 to
ad329ee
Compare
rambohe-ch
force-pushed
the
upgrade-to-node-claim
branch
from
ad329ee to
4e26221
Compare
rambohe-ch
force-pushed
the
upgrade-to-node-claim
branch
from
4e26221 to
a7a8f5b
Compare
rambohe-ch
force-pushed
the
upgrade-to-node-claim
branch
from
a7a8f5b to
9acc2b7
Compare
rambohe-ch
force-pushed
the
upgrade-to-node-claim
branch
from
9acc2b7 to
f739e3a
Compare
rambohe-ch
changed the title
1. upgrade CRD: Machine to NodeClaim 2. update aws/karpenter-core to sigs.k8s.io/karpenter 3. add webhook for v1beta1.NodeClaim and v1.NodeClaim conversion 4. add instance garbage collection controller for cleanuping leaked cloud provider instance and node. 5. remove unused files like sku, pricing, instancetype, etc. 6. improve nodeclaim garbage collection: launch error cases: if node was not ready for more than 10min, we recognize this node crashed and delete nodeclaim for triggering to create a new node. 7. add unit test cases Signed-off-by: rambohe-ch <rambohe.ch@gmail.com>
rambohe-ch
force-pushed
the
upgrade-to-node-claim
branch
from
f739e3a to
a00cb7c
Compare
rambohe-ch
changed the title
Fei-Guo
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.