-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: harden harden-runner egress policy #477
Conversation
Pull Request Test Coverage Report for Build 10729088440Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks pretty good. Mostly nits.
However, do have a bit larger concern for dev flow impact. If we update the workflows, and need to add new allowed-endpoints, will there be an easy way to determine what those endpoints we need to add are?
Also, need to confirm E2E tests pass.
Yes, likely using either the failure itself or Harden Runner post-action log (or report in the action run summary). If this fails - setting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. 1 nit
Ok, sounds good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* fix: harden harden-runner egress policy * doc: add comments * doc: fix typo
Description
Switch to Harden Runner
egress-policy: block
, add selectedallowed-endpoints
. Alsodisable-telemetry: true
for now.The endpoints come from StepSecurity insights for corresponding runs (such as this one; "Recommendations" tab as base, "Networks Events" for further drill down), with some selected wildcarding (to accommodate variations) and removals (mostly things that are no longer used, but might still be reported in the cumulative insights). Notes and outliers:
9236a389bd48b984df91adc1bc924620.r2.cloudflarestorage.com
- blob storage for cgr.dev, and we no longer use Chainguard for base imagesclients3.google.com:80
andfirebaselogging-pa.googleapis.com:443
- confirmed Skaffold, likely telemetry, likely can be avoided/blocked with/afterskaffold config set --global collect-metrics false
How was this change tested?
Does this change impact docs?
Release Note