[Feature] Add Facebook Custom Auth Support #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
scope: core
cjk7989
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
For the comments in Line 15:
// only match for providers with custom auth support implemented (github, google, aad)
Should we update the supported provider type?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New feature: Adding Facebook custom auth support using Facebook's manual OIDC token flow. A few more refactors had to be done to the previous code since Facebook's flow is a little bit different, mainly:
Testing
staticwebapp.config.json:
Facebook /.auth/me:
Github /.auth/me:
AAD /.auth/me:
Google /.auth/me:
