Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hub_routing_preference to connectivity advanced configuration #930

Merged
merged 2 commits into from
May 10, 2024

Conversation

QBY-MarkusMaring
Copy link
Contributor

Overview/Summary

This PR adds the hub_routing_preference option to the advanced configuration section of azurerm_virtual_hub.
The default value is the same as for the azurerm provider ("ExpressRoute") so by default no changes will occur when upgrading.
There doesn't seem to be documentation for advanced configs that needs to be updated, let me know if I just missed it and I will update it.

This PR relates to issue #861

See azurerm documentation for this option here

This PR fixes/adds/changes/removes

  1. Adds hub_routing_preference option

Breaking Changes

Testing Evidence

In a local test I've modified the custom_settings_by_resource_type block of tests/modules/settings/settings.connectivity.tf to include the following:

azurerm_virtual_hub = {
  virtual_wan = {
    (var.primary_location) = {
      hub_routing_preference = "ASPath"
    }
  }
}

Planning tests/modules/test_003_add_mgmt_conn will show that the hub_routing_preference for the primary location hub has changed accordingly and that the secondary location hub maintains it's default configuration "ExpressRoute":
image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@QBY-MarkusMaring
Copy link
Contributor Author

@microsoft-github-policy-service agree company="q.beyond AG"

@ghost ghost mentioned this pull request May 7, 2024
@matt-FFFFFF
Copy link
Member

/azp run unit

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@matt-FFFFFF matt-FFFFFF merged commit f7e8114 into Azure:main May 10, 2024
8 of 9 checks passed
anmolnagpal pushed a commit to clouddrove/terraform-azure-landingzone that referenced this pull request Jul 8, 2024
* feat(connectivity): Add option to set allow_non_virtual_wan_traffic in express route gateway. (Azure#914)

Co-authored-by: Miltos Tsatsakis <[email protected]>

* updates to resolve issue Azure#794 (Azure#919)

Co-authored-by: github-actions <[email protected]>

* docs: update docs for threat_intelligence_allowlist (Azure#928)

* Update wiki-sync.yml

* chore(deps): bump github/super-linter from 5 to 6 (Azure#931)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* add link to Upgrade guide from v4.2.0 to v5.0.0 (Azure#934)

Co-authored-by: Matt White <[email protected]>

* Added hub_routing_preference to connectivity advanced configuration (Azure#930)

* Policy sync updates (Azure#959)

* Update Library Templates (automated) (Azure#966)

Co-authored-by: github-actions <[email protected]>

* Add remote branch option (Azure#970)

* Update Library Templates (automated) (Azure#973)

Co-authored-by: github-actions <[email protected]>

* Update Library Templates (automated) (Azure#976)

Co-authored-by: github-actions <[email protected]>

* Remove redundant assignment file (Azure#977)

* updating threat intelligence allowlist dynamic block (Azure#953)

Co-authored-by: Matt White <[email protected]>

* chore(deps): bump azure/powershell from 1 to 2 (Azure#917)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add OpenSFF Scorecard (Azure#987)

* chore(deps): bump github/codeql-action from 3.24.9 to 3.25.8 (Azure#990)

* chore(deps): bump github.com/hashicorp/go-getter from 1.7.3 to 1.7.4 in /tests/terratest (Azure#986)

* feat!: ama (Azure#968)

* Fix example uami issue (Azure#1000)

* Update Library Templates (automated) (Azure#1001)

Co-authored-by: github-actions <[email protected]>

* docs: additional v6 upgrade detail (Azure#1002)

* Update Library Templates (automated) (Azure#1006)

Co-authored-by: github-actions <[email protected]>

* docs: update docs with FAQ on roadmap and banner for upcoming breaking changes (Azure#1008)

* naming fixed in module

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Mtsa <[email protected]>
Co-authored-by: Miltos Tsatsakis <[email protected]>
Co-authored-by: Adam Tuckwell <[email protected]>
Co-authored-by: github-actions <[email protected]>
Co-authored-by: Jared Holgate <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tobias <[email protected]>
Co-authored-by: Matt White <[email protected]>
Co-authored-by: QBY-MarkusMaring <[email protected]>
Co-authored-by: cae-pr-creator[bot] <126156663+cae-pr-creator[bot]@users.noreply.github.com>
Co-authored-by: Daan Toes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants