Added hub_routing_preference to connectivity advanced configuration #930
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
This PR adds the hub_routing_preference option to the advanced configuration section of azurerm_virtual_hub.
The default value is the same as for the azurerm provider ("ExpressRoute") so by default no changes will occur when upgrading.
There doesn't seem to be documentation for advanced configs that needs to be updated, let me know if I just missed it and I will update it.
This PR relates to issue #861
See azurerm documentation for this option here
This PR fixes/adds/changes/removes
Breaking Changes
Testing Evidence
In a local test I've modified the custom_settings_by_resource_type block of
tests/modules/settings/settings.connectivity.tf
to include the following:Planning
![image](https://private-user-images.githubusercontent.com/106068259/324841969-7806ad21-7c0c-423b-9298-be9b66003e36.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NzU1ODQsIm5iZiI6MTczOTY3NTI4NCwicGF0aCI6Ii8xMDYwNjgyNTkvMzI0ODQxOTY5LTc4MDZhZDIxLTdjMGMtNDIzYi05Mjk4LWJlOWI2NjAwM2UzNi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNlQwMzA4MDRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iMjMwYTdhYzdlMGQ1MmUwNGE4OWQ5YWViNDliY2NmNGMxZDY3OTQ2NzczNGRmN2Y5ODBjZGI5NjgxNDljMDZhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.YacN4IUz4rC8okNL8hNiYY3KQSKyBQVy1-Jzc0Q0uSA)
tests/modules/test_003_add_mgmt_conn
will show that the hub_routing_preference for the primary location hub has changed accordingly and that the secondary location hub maintains it's default configuration "ExpressRoute":As part of this Pull Request I have
main
branch