Skip to content

Commit

Permalink
fix: virtual_networks value type & README (#120)
Browse files Browse the repository at this point in the history
* fix: correct value type from string to bool.

* chore: update module version

* docs: make docs
  • Loading branch information
matt-FFFFFF authored Nov 8, 2022
1 parent 86ea17b commit 90b2b59
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 9 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ Description: A map of the virtual networks to create. The map key must be known
### Required fields

- `name`: The name of the virtual network. [required]
- `address_space`: The address space of the virtual network as a list of strings in CIDR format, e.g. ["192.168.0.0/24, 10.0.0.0/24"]. [required]
- `address_space`: The address space of the virtual network as a list of strings in CIDR format, e.g. `["192.168.0.0/24", "10.0.0.0/24"]`. [required]
- `resource_group_name`: The name of the resource group to create the virtual network in. [required]

### Location
Expand Down Expand Up @@ -453,7 +453,7 @@ map(object({
resource_group_name = string
hub_network_resource_id = optional(string, "")
hub_peering_enabled = optional(string, false)
hub_peering_enabled = optional(bool, false)
hub_peering_name_tohub = optional(string, "")
hub_peering_name_fromhub = optional(string, "")
hub_peering_use_remote_gateways = optional(bool, true)
Expand Down
2 changes: 1 addition & 1 deletion locals.version.tf.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"locals": {
"module_version": "2.0.1"
"module_version": "2.0.2"
}
}
6 changes: 4 additions & 2 deletions modules/virtualnetwork/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ Description: A map of the virtual networks to create. The map key must be known
### Required fields

- `name`: The name of the virtual network. [required]
- `address_space`: The address space of the virtual network as a list of strings in CIDR format, e.g. ["192.168.0.0/24, 10.0.0.0/24"]. [required]
- `address_space`: The address space of the virtual network as a list of strings in CIDR format, e.g. `["192.168.0.0/24", "10.0.0.0/24"]`. [required]
- `resource_group_name`: The name of the resource group to create the virtual network in. [required]

### Location
Expand Down Expand Up @@ -133,8 +133,10 @@ map(object({
location = optional(string, "")
dns_servers = optional(list(string), [])
hub_network_resource_id = optional(string, "")
hub_peering_enabled = optional(string, false)
hub_peering_enabled = optional(bool, false)
hub_peering_name_tohub = optional(string, "")
hub_peering_name_fromhub = optional(string, "")
hub_peering_use_remote_gateways = optional(bool, true)
Expand Down
6 changes: 4 additions & 2 deletions modules/virtualnetwork/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,10 @@ variable "virtual_networks" {

location = optional(string, "")

dns_servers = optional(list(string), [])

hub_network_resource_id = optional(string, "")
hub_peering_enabled = optional(string, false)
hub_peering_enabled = optional(bool, false)
hub_peering_name_tohub = optional(string, "")
hub_peering_name_fromhub = optional(string, "")
hub_peering_use_remote_gateways = optional(bool, true)
Expand Down Expand Up @@ -72,7 +74,7 @@ A map of the virtual networks to create. The map key must be known at the plan s
### Required fields
- `name`: The name of the virtual network. [required]
- `address_space`: The address space of the virtual network as a list of strings in CIDR format, e.g. ["192.168.0.0/24, 10.0.0.0/24"]. [required]
- `address_space`: The address space of the virtual network as a list of strings in CIDR format, e.g. `["192.168.0.0/24", "10.0.0.0/24"]`. [required]
- `resource_group_name`: The name of the resource group to create the virtual network in. [required]
### Location
Expand Down
4 changes: 2 additions & 2 deletions variables.virtualnetwork.tf
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ variable "virtual_networks" {
resource_group_name = string

hub_network_resource_id = optional(string, "")
hub_peering_enabled = optional(string, false)
hub_peering_enabled = optional(bool, false)
hub_peering_name_tohub = optional(string, "")
hub_peering_name_fromhub = optional(string, "")
hub_peering_use_remote_gateways = optional(bool, true)
Expand Down Expand Up @@ -57,7 +57,7 @@ A map of the virtual networks to create. The map key must be known at the plan s
### Required fields
- `name`: The name of the virtual network. [required]
- `address_space`: The address space of the virtual network as a list of strings in CIDR format, e.g. ["192.168.0.0/24, 10.0.0.0/24"]. [required]
- `address_space`: The address space of the virtual network as a list of strings in CIDR format, e.g. `["192.168.0.0/24", "10.0.0.0/24"]`. [required]
- `resource_group_name`: The name of the resource group to create the virtual network in. [required]
### Location
Expand Down

0 comments on commit 90b2b59

Please sign in to comment.