Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[arm-common-types] - closing gaps & validation with compare tool #1881

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[arm-common-types] - closing gaps & validation with compare tool #1881

wants to merge 7 commits into from

Conversation

AlitzelMendez
Copy link
Member

@AlitzelMendez AlitzelMendez commented Nov 18, 2024 •
edited
Loading

common-types still have some differences, we want to remove as much differences as possible so we can call common-types "ready"

issue: #1882

@AlitzelMendez AlitzelMendez changed the title Common-types - closing gaps & validation with compare tool [arm-common-types] - closing gaps & validation with compare tool Nov 18, 2024
@AlitzelMendez AlitzelMendez mentioned this pull request Nov 18, 2024
Open
@azure-sdk
Copy link
Collaborator

azure-sdk commented Nov 18, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @azure-tools/typespec-azure-resource-manager
Show changes

@azure-tools/typespec-azure-resource-manager - feature ✏️

common-types consistency with original swagger

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@AlitzelMendez AlitzelMendez changed the title [arm-common-types] - closing gaps & validation with compare tool [WIP][arm-common-types] - closing gaps & validation with compare tool Nov 21, 2024
@AlitzelMendez AlitzelMendez changed the title [WIP][arm-common-types] - closing gaps & validation with compare tool [arm-common-types] - closing gaps & validation with compare tool Nov 25, 2024
@AlitzelMendez AlitzelMendez marked this pull request as ready for review November 25, 2024 17:31
@AlitzelMendez AlitzelMendez linked an issue Nov 25, 2024 that may be closed by this pull request
[arm-common-types] Consistency in our common types comparing with "compare tool" #1882
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@markcowl markcowl

@allenjzhang allenjzhang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[arm-common-types] Consistency in our common types comparing with "compare tool"
4 participants
@AlitzelMendez @azure-sdk @markcowl @allenjzhang