Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more logging to GetAccounts by id #4929

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add more logging to GetAccounts by id #4929

wants to merge 5 commits into from

Conversation

bgavrilMS
Copy link
Member

Fixes #

Changes proposed in this request

Testing

Performance impact

Documentation

  • All relevant documentation is updated.

@bgavrilMS bgavrilMS marked this pull request as ready for review October 11, 2024 14:46
@bgavrilMS bgavrilMS requested a review from a team as a code owner October 11, 2024 14:46
trwalke
trwalke reviewed Oct 11, 2024
View reviewed changes
...crosoft.Identity.Test.Integration.netcore/HeadlessTests/ClientCredentialsTests.WithRegion.cs
{
builder.WithCertificate(settings.GetCertificate());
}
//if (useClaims)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code?

trwalke
trwalke approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@trwalke trwalke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trwalke trwalke trwalke approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bgavrilMS @trwalke