Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding variables to code coverage check #5000

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Adding variables to code coverage check #5000

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82a6ba2
Adding variables to code coverage check
trwalke Nov 19, 2024
c4b99da
Update template-build-and-run-all-tests.yaml
trwalke Nov 19, 2024
93d3b74
Update template-build-and-run-all-tests.yaml
trwalke Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions build/template-build-and-run-all-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,13 +69,14 @@ jobs: #Build and stage projects
- template: template-desktop-unit-and-automation.yaml

- task: BuildQualityChecks@9
condition: ne(variables['Build.SourceBranch'], 'refs/heads/main') #gate should not run on main branch
inputs:
checkCoverage: true
checkCoverage: '$(CodeCoverageGateEnabled)'
coverageFailOption: 'build'
coverageType: 'lines'
treat0of0as100: true
forceCoverageImprovement: true
coverageUpperThreshold: '90'
coverageUpperThreshold: '$(CodeCoverageUpperThreshold)' #default of 90
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this one, the build already has too many variables.

includePartiallySucceeded: false
fallbackOnPRTargetBranch: false
baseDefinitionId: '905' #this is the PR build and it is used as a baseline
Expand Down
Loading