Merge branch 'dev' into client_credentials_regression_test

AzureAD · Sep 12, 2023 · 345a21f · 345a21f
2 parents 64b41f3 + 2bc6389
commit 345a21f
Show file tree

Hide file tree

Showing 6 changed files with 25 additions and 12 deletions.
diff --git a/CODEOWNERS b/CODEOWNERS
@@ -16,11 +16,6 @@
 /samples/msal-node-samples/ @sameerag @tnorling @hectormmg @peterzenz @bgavrilMS @robbie-microsoft
 /extensions/msal-node-extensions/ @sameerag @tnorling @hectormmg @peterzenz
 
-# MSAL Node Confidential Client Regression Tests
-.github/workflows/client-credential-benchmark.yml @bgavrilMS @robbie-microsoft @trwalke @pmaytak @gladjohn @neha-bhargava @rayluo @Avery-Dunn
-.github/workflows/msal-node-confidential-client-benchmarks.yml @bgavrilMS @robbie-microsoft @trwalke @pmaytak @gladjohn @neha-bhargava @rayluo @Avery-Dunn
-/regression-tests/msal-node/ @bgavrilMS @robbie-microsoft @trwalke @pmaytak @gladjohn @neha-bhargava @rayluo @Avery-Dunn
-
 # MSAL React
 /lib/msal-react/ @tnorling @jo-arroyo @peterzenz
 /samples/msal-react-samples/ @tnorling @jo-arroyo @peterzenz
@@ -31,5 +26,10 @@
 /.github/ @sameerag @tnorling @hectormmg @peterzenz
 /.pipelines/ @hectormmg @tnorling @peterzenz
 
+# MSAL Node Confidential Client Regression Tests
+.github/workflows/client-credential-benchmark.yml @bgavrilMS @robbie-microsoft @trwalke @pmaytak @gladjohn @neha-bhargava @rayluo @Avery-Dunn
+.github/workflows/msal-node-confidential-client-benchmarks.yml @bgavrilMS @robbie-microsoft @trwalke @pmaytak @gladjohn @neha-bhargava @rayluo @Avery-Dunn
+/regression-tests/msal-node/ @bgavrilMS @robbie-microsoft @trwalke @pmaytak @gladjohn @neha-bhargava @rayluo @Avery-Dunn
+
 # Filepaths to ignore
 /change/
diff --git a/change/@azure-msal-browser-e4c3386d-0fd8-4875-bef9-4c16a6b530b1.json b/change/@azure-msal-browser-e4c3386d-0fd8-4875-bef9-4c16a6b530b1.json
@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "doc: JSDoc for deprecated BrowserAuthErrorMessage",
+  "packageName": "@azure/msal-browser",
+  "email": "[email protected]",
+  "dependentChangeType": "none"
+}
diff --git a/lib/msal-browser/src/error/BrowserAuthError.ts b/lib/msal-browser/src/error/BrowserAuthError.ts
@@ -92,7 +92,11 @@ export const BrowserAuthErrorMessages = {
 
 /**
  * BrowserAuthErrorMessage class containing string constants used by error codes and messages.
- * @deprecated Use BrowserAuthBrowserAuthErrorCodes instead
+ * @deprecated Use exported BrowserAuthErrorCodes instead.
+ * In your app you can do :
+ * ```
+ * import { BrowserAuthErrorCodes } from "@azure/msal-browser";
+ * ```
  */
 export const BrowserAuthErrorMessage = {
     pkceNotGenerated: {

diff --git a/samples/msal-browser-samples/vue3-sample-app/README.md b/samples/msal-browser-samples/vue3-sample-app/README.md
@@ -1,4 +1,4 @@
-# MSAL.js 2.x + Vue 3 + TypeScript Sample
+# MSAL.js + Vue 3 + TypeScript Sample
 
 ## About this sample
 

diff --git a/samples/msal-browser-samples/vue3-sample-app/package.json b/samples/msal-browser-samples/vue3-sample-app/package.json
@@ -8,7 +8,7 @@
     "build:package": "cd ../../../lib/msal-browser && npm run build:all"
   },
   "dependencies": {
-    "@azure/msal-browser": "^3.0.0-beta.0",
+    "@azure/msal-browser": "^3.1.0",
     "element-plus": "^2.2.19",
     "vue": "^3.2.41",
     "vue-router": "^4.1.5"
@@ -19,4 +19,4 @@
     "vite": "^3.1.8",
     "vue-tsc": "^1.0.8"
   }
-}
+}
diff --git a/samples/msal-browser-samples/vue3-sample-app/src/composition-api/useMsal.ts b/samples/msal-browser-samples/vue3-sample-app/src/composition-api/useMsal.ts
@@ -19,9 +19,11 @@ export function useMsal(): MsalContext {
     }
 
     if (inProgress.value === InteractionStatus.Startup) {
-        instance.value.handleRedirectPromise().catch(() => {
-            // Errors should be handled by listening to the LOGIN_FAILURE event
-            return;
+        instance.value.initialize().then(() => {
+            instance.value.handleRedirectPromise().catch(() => {
+                // Errors should be handled by listening to the LOGIN_FAILURE event
+                return;
+            });
         });
     }