Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Region auto enable on env variable #7354

Merged
merged 15 commits into from
Oct 31, 2024
Merged

Region auto enable on env variable #7354

merged 15 commits into from
Oct 31, 2024

Conversation

Robbie-Microsoft
Copy link
Collaborator

On creation of a ConfidentialClientApplication, MSAL shall detect env variable MSAL_FORCE_REGION, which will be set to a specific region (e.g. westus1)

If this env variable is set, MSAL shall opt-in to ESTS-R with the value of this variable.

This feature request is located here.

@Robbie-Microsoft Robbie-Microsoft linked an issue Oct 1, 2024 that may be closed by this pull request
Copy link
Member

@bgavrilMS bgavrilMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment about disable

Copy link
Member

@bgavrilMS bgavrilMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests look great now, thanks!

@Robbie-Microsoft Robbie-Microsoft requested a review from a team as a code owner October 30, 2024 23:14
@Robbie-Microsoft Robbie-Microsoft merged commit 098a957 into dev Oct 31, 2024
7 of 8 checks passed
@Robbie-Microsoft Robbie-Microsoft deleted the region_env_variable branch October 31, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
msal-node Related to msal-node package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Region auto enable on env variable
4 participants