Collect additional telemetry for crypto/runtime errors #7394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tnorling
commented
Oct 22, 2024
tnorling
commented
- Adds additional check for the subtle property on crypto
- Fixes error stack logic to keep top 5 lines instead of bottom 5
- Collects common, known runtime errors and redacts when necessary
github-actions
bot
added
msal-browser
tnorling
requested review from
sameerag,
hectormmg,
jo-arroyo,
peterzenz,
Robbie-Microsoft,
konstantin-msft,
lalimasharda and
shylasummers
as code owners
konstantin-msft
approved these changes
Oct 24, 2024
sameerag
reviewed
Oct 29, 2024
| ) { | ||
| const line = stackArr[ix]; | ||
| // These types of errors are not at risk of leaking PII. They will indicate unavailable APIs |
There was a problem hiding this comment.
Yes, these are thrown when we call an API or access an object property that doesn't exist, neither of which are PII and we control this.
There was a problem hiding this comment.
*can we get a guidance to the team so folks don't accidentally add PII?
There was a problem hiding this comment.
I'm saying there's not a risk of that. APIs and object properties are not PII
sameerag
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.