-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: move some code under comp/
#720
base: main
Are you sure you want to change the base?
src: move some code under comp/
#720
Conversation
The top-level structure under `src/` is awkward and it's unclear why Parsec is here. Why not `vendor/`? Ultimately though, I think the best place is actually inside the source code, because it's not like anything else uses it and it's `bsc`-owned code already in practice anyway. Signed-off-by: Austin Seipp <[email protected]>
And once again I forget that I tried to do this before, though, only for Parsec: #34 But the effort to migrate to upstream Parsec has stalled out. It's been several years. Unless someone is working on it, let's just do it and take the small win for now — I think taking this commit would be good just to clean up the codebase. I have a lot of other thoughts improving the build process but I won't put them here. So I think we should still just do these. |
cd93554
to
462538b
Compare
Similarly to Parsec, this code is practically only used in one spot, so it might as well be maintained there. I don't even know what codebase HTcl is a 'vendoring' *of* and it's dated to over 15 years ago at minimum, so it's probably lost to history now... Just put it all together for clarity and ease of development. Signed-off-by: Austin Seipp <[email protected]>
462538b
to
c778cc8
Compare
Moving Instead of moving things under I guess, since
I notice that |
The commit descriptions for each commit contain most of the detail. But in short: I don't see why they're spread out elsewhere when they are de facto part of the
comp
codebase. So just move them there.