Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2 fa #58

Closed
wants to merge 26 commits into from
Closed

2 fa #58

wants to merge 26 commits into from

Conversation

B-ki
Copy link
Owner

@B-ki B-ki commented Nov 13, 2023

Still a problem to solve :
If 2fa activated, after login, a token is set, so it's possible to reach all pages.
Solutions available :

  • Front token logic : If 2FA enabled and 2FA auth not validated -> setToken(null). Need to add a isTwoFaAuthSuccess: boolean in the jwtToken
  • API : Enable 2FA connection without any guard, ands setToken after 2FA is enabled

B-ki and others added 24 commits November 6, 2023 19:08
@B-ki
Starting 2FA
dc7bc6a
@B-ki
QR code activated
4ea1517
@B-ki
Cleaning file
3f94899
@B-ki
Error trying to give prop to component TwoFaInputLogin
5e9456b
@B-ki
Nearly done 2FA, need to fix jwt token creation now
1b03c94
@B-ki
2 problems : Can't SetToken in TwoFaInputLogin because mutation retur…
8a6ffea 
…ns nothing, and can't pass parameters while navigating
@B-ki
Need to set the newtoken
aa13654
@B-ki
Little ts error on a data type but all good, need to upgrade jwtToken…
cabc553 
… decoding in private guard
@Bilaboz @B-ki
channel leave + send message
a842842
@Bilaboz @B-ki
message history + update channel password/visibility
3c0a536
@Bilaboz @B-ki
channel list + joined channels list
ab7b834
@Bilaboz @B-ki
user list in channel
88d4b09
@Bilaboz @B-ki
block other users
ee58728
@Bilaboz @B-ki
add pagination for message history
5bd20d1
@Bilaboz @B-ki
channel administrators
1ce2073
@Bilaboz @B-ki
kick + ban
51c0a5f
@Bilaboz @B-ki
temp mute
2c8f3cf
@Bilaboz @B-ki
direct messages
b01f5fd
@Bilaboz @B-ki
delete leftover file
e427c5c
@Bilaboz @B-ki
rename chat events file
aea3fd0
@Bilaboz @B-ki
fix typo
e0366fe
@B-ki
Starting 2FA
48f0b1f
@B-ki
Fixing rebase conflicts
2dcd488
@B-ki
Fixing rebase conflicts
fea98f7
@B-ki B-ki closed this Nov 13, 2023
@B-ki B-ki reopened this Nov 13, 2023
@B-ki B-ki closed this Nov 13, 2023
@B-ki B-ki deleted the 2FA branch November 13, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@B-ki @Bilaboz