Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure that parameter have correct units #122

Closed
eriktamsen opened this issue Jul 12, 2023 · 2 comments · Fixed by #141
Closed

Make sure that parameter have correct units #122

eriktamsen opened this issue Jul 12, 2023 · 2 comments · Fixed by #141

Comments

@eriktamsen
Copy link
Member

Apparently currently the parameters are just check to have any kind of unit, but we need to make sure they have the right ones.
@srosenbu
Copy link
Member

This seems like an easy fix. We just need to compare the units in the input dictionary to the ones in the defualt dictionary

@srosenbu srosenbu mentioned this issue Aug 28, 2023
Closed
@aradermacher
Copy link
Collaborator

I suggest to move all parameters into default and load those as default in the init, updating with the on set by the user.

@aradermacher aradermacher linked a pull request Sep 15, 2023 that will close this issue
122 make sure that parameter have correct units #141
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

122 make sure that parameter have correct units BAMresearch/FenicsXConcrete
3 participants
@aradermacher @srosenbu @eriktamsen