122 make sure that parameter have correct units #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 15, 2023 14:12
…ce, move all parameter decleration into default_parameters function
srosenbu
reviewed
Sep 15, 2023
|
There are two unit problems in the concrete_thermal problem (E_act, Thermal_cond) The test_default_dictonaries doe snot make sense anymore. |
|
@srosenbu Please have a look |
srosenbu
requested changes
Oct 5, 2023
src/fenicsxconcrete/finite_element_problem/concrete_thermo_mechanical.py
Outdated
Show resolved
Hide resolved
src/fenicsxconcrete/finite_element_problem/concrete_thermo_mechanical.py
Outdated
Show resolved
Hide resolved
src/fenicsxconcrete/finite_element_problem/concrete_thermo_mechanical.py
Outdated
Show resolved
Hide resolved
…hanical.py Co-authored-by: Sjard Mathis Rosenbusch <[email protected]>
…hanical.py Co-authored-by: Sjard Mathis Rosenbusch <[email protected]>
…hanical.py Co-authored-by: Sjard Mathis Rosenbusch <[email protected]>
aradermacher
deleted the
122-make-sure-that-parameter-have-correct-units
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@srosenbu: I add an possible solution for the experiment parameters (see base_experiment)
Please have a look and we can discuss and extend that to teh material_problems