Avoid broadcasting over a Q matrix (#17)

* Avoid broadcasting over a `Q` matrix
BBN-Q · Sep 17, 2022 · fe7cbe0 · fe7cbe0 · dkarrasch · Dec 14, 2022
1 parent 39f7496
commit fe7cbe0
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/RandomQuantum.jl b/src/RandomQuantum.jl
@@ -130,10 +130,10 @@ end
 
 function rand(dist::ClosedHaarEnsemble)
     X = rand(GinibreEnsemble(dist.dim))
-    Q,_ = qr(X)
+    Q = qr(X).Q * eye(dist.dim) # yields dense square matrix
     d = diag(Q)
-    d = d ./ abs.(d)
-    Q = Q ./ d
+    d ./= abs.(d)
+    Q ./= d
     return Q
 end