Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hoist DM plan stubs from XPCS and make generic #20

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Conversation

@prjemian prjemian self-assigned this Nov 11, 2024
@coveralls
Copy link

coveralls commented Nov 11, 2024

Pull Request Test Coverage Report for Build 11924512046

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 13 of 37 (35.14%) changed or added relevant lines in 2 files are covered.
  • 12 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-3.1%) to 79.889%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/instrument/plans/dm_plans.py 10 34 29.41%
Files with Coverage Reduction New Missed Lines %
src/instrument/startup.py 3 89.66%
src/instrument/utils/helper_functions.py 9 71.43%
Totals Coverage Status
Change from base Build 11713321871: -3.1%
Covered Lines: 433
Relevant Lines: 542

💛 - Coveralls

Copy link
Collaborator

@MDecarabas MDecarabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think if we add a README that showcases how to use the plan with a set of example inputs we're golden

@prjemian
Copy link
Collaborator Author

prjemian commented Nov 20, 2024

The README is getting a bit fat if this content is added directly. Instead (applying D.R.Y.), added it to the docs and linked from the README to that location.

@prjemian prjemian merged commit be01d54 into main Nov 20, 2024
5 checks passed
@prjemian prjemian deleted the 19-hoist-DM-from-XPCS branch November 20, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants