StoredDict is alternative to PersistentDict #30
Conversation
Pull Request Test Coverage Report for Build 12182630881Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
src/instrument/configs/iconfig.yml
Outdated
| # MD_STORAGE_HANDLER: PersistentDict | ||
| # MD_PATH: HOME/.config/Bluesky_RunEngine_md' |
There was a problem hiding this comment.
let's go ahead and remove this if we don't need it
There was a problem hiding this comment.
Ok, we'll drop this as an alternative.
There was a problem hiding this comment.
see commit 96657d2
There was a problem hiding this comment.
If this is just a test file should it not live inside the tests?
There was a problem hiding this comment.
Looks like it's there now.
| except Exception as e: | ||
| handler = { | ||
| "PersistentDict": bluesky.utils.PersistentDict, | ||
| "StoredDict": StoredDict, |
There was a problem hiding this comment.
Seems like we are instantiating the StoredDict class exclusively in this dictionary, however at no point are we passing arguments or using the class to do anything. Am I missing something
There was a problem hiding this comment.
Here, the StoredDict replaces the default RE.md structure:
There was a problem hiding this comment.
This commit 96657d2 makes this more obvious.
Make StoredDict the default. Keep the code that handles PersistentDict as an option, in case someone wants to use it. Add usage documentation about the MD_PATH.
|
@MDecarabas All your review comments are addressed. Please review again. |
@qzhang234 : Your bug report pushed this along!