Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#242 로그인 버그 픽스 #251

Merged
merged 3 commits into from
Jun 29, 2024
Merged

Feature/#242 로그인 버그 픽스 #251

merged 3 commits into from
Jun 29, 2024

Conversation

jasper200207
Copy link
Collaborator

관련 이슈

작업 요약

  • 제대로 돌아가는 로그인 버그 픽스

작업 상세 설명

  • 초기 렌더링시 jotai 상태값이 저장된 값이 아닌 초기값으로 나오는 현상으로 인해 useEffect로 마운트 여부 확인기능 추가
  • fetch 성공시 ok가 없는거 수정

리뷰 요구 사항

  • 리뷰 예상 시간 : 2분

@jasper200207 jasper200207 added the 🐞 버그 예기치 못한 동작 발생 label Jun 29, 2024
@jasper200207 jasper200207 self-assigned this Jun 29, 2024
pipisebastian
pipisebastian approved these changes Jun 29, 2024
View reviewed changes
Copy link
Member

@pipisebastian pipisebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구시에욤~~~

mun-kyeong
mun-kyeong approved these changes Jun 29, 2024
View reviewed changes
Copy link
Collaborator

@mun-kyeong mun-kyeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다~

@jasper200207 jasper200207 merged commit 692c92d into develop Jun 29, 2024
1 check passed
@jasper200207 jasper200207 deleted the Feature/#242-로그인_버그_픽스 branch June 29, 2024 11:23
llddang
llddang approved these changes Jun 29, 2024
View reviewed changes
Copy link
Collaborator

@llddang llddang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llddang llddang llddang approved these changes

@pipisebastian pipisebastian pipisebastian approved these changes

@mun-kyeong mun-kyeong mun-kyeong approved these changes

@yeonddori yeonddori Awaiting requested review from yeonddori

Assignees

@jasper200207 jasper200207

Labels
🐞 버그 예기치 못한 동작 발생
Projects
01-doo-re
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIX] 로그인 버그 픽스
4 participants
@jasper200207 @llddang @pipisebastian @mun-kyeong