Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#228 팀페이지, 스터디 페이지 학습자료 crud #252

Conversation

mun-kyeong
Copy link
Collaborator

관련 이슈

작업 요약

  • 학습자료 CRUD 입니당

작업 상세 설명

  • api docs 참고해서 작성했습니다~!

리뷰 요구 사항

  • 흠 조금 가물가물해서 혹시나 잘못된 부분 잇음 알려주세요

김문경 and others added 8 commits May 30, 2024 18:57
…into feature/#228-팀페이지,-스터디-페이지-학습자료-CRUD
…into feature/#228-팀페이지,-스터디-페이지-학습자료-CRUD
…into feature/#228-팀페이지,-스터디-페이지-학습자료-CRUD
…into feature/#228-팀페이지,-스터디-페이지-학습자료-CRUD
…into feature/#228-팀페이지,-스터디-페이지-학습자료-CRUD
@mun-kyeong mun-kyeong added the 📬 API 서버 API 통신 label Jun 29, 2024
@mun-kyeong mun-kyeong self-assigned this Jun 29, 2024
Copy link
Collaborator

@jasper200207 jasper200207 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@pipisebastian pipisebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구시에욤!

Copy link
Collaborator

@llddang llddang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

src/types.ts Outdated

export type DocumentAccessType = 'TEAM' | 'STUDY' | 'ALL';

export type DocumentType = 'FILE' | 'IMAGE' | 'URL';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(image, document, url) api 문서에서는 type에 들어갈 수 있는 문자열이 FILE이 아니라 DOCUMENT인 것 같습니다.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우앗 감사합니다! 수정해둘게요

@mun-kyeong mun-kyeong merged commit 2bcc55e into develop Jun 29, 2024
1 check passed
@mun-kyeong mun-kyeong deleted the feature/#228-팀페이지,-스터디-페이지-학습자료-CRUD branch June 29, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📬 API 서버 API 통신
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] 팀페이지, 스터디 페이지 학습자료 CRUD
4 participants