Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#280 스터디 목록 조회 api 연결 #281

Merged
merged 4 commits into from
Jul 15, 2024
Merged

Feature/#280 스터디 목록 조회 api 연결 #281

merged 4 commits into from
Jul 15, 2024

Conversation

yeonddori
Copy link
Collaborator

관련 이슈

작업 요약

  • 스터디 목록 조회 api 연결했습니다.

리뷰 요구 사항

  • Feature/#249 스터디 crud api 연결 선행 리뷰 부탁드립니다!! 해당 pr을 기반으로 코드를 짰습니다.
  • 타입을 정확히 어떻게 지정하자고 했는지 가물가물해서.. 맞는지 확인 부탁드립니다!
  • 리뷰 예상 시간: 5분

미리 보기

image

@yeonddori yeonddori added the 📬 API 서버 API 통신 label Jul 10, 2024
@yeonddori yeonddori self-assigned this Jul 10, 2024
jasper200207
jasper200207 approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@jasper200207 jasper200207 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

jasper200207
jasper200207 requested changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@jasper200207 jasper200207 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

./src/app/team/[teamId]/study/[studyId]/page.tsx:33:36
Type error: Property 'name' does not exist on type 'StudyCardProps'.

build 오류 났습니다... 자세한 메세지는 build_test details에서 확인 가능합니다!

@jasper200207 jasper200207 self-requested a review July 11, 2024 06:33
jasper200207
jasper200207 approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@jasper200207 jasper200207 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

mun-kyeong
mun-kyeong approved these changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@mun-kyeong mun-kyeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

llddang
llddang approved these changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@llddang llddang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

Merge branch 'develop' of https://github.com/BDD-CLUB/01-doo-re-front …
7c7719a 
…into Feature/#280-스터디_목록_조회_api_연결
@yeonddori yeonddori merged commit 76f1764 into develop Jul 15, 2024
1 check passed
@yeonddori yeonddori deleted the Feature/#280-스터디_목록_조회_api_연결 branch July 15, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mun-kyeong mun-kyeong mun-kyeong approved these changes

@llddang llddang llddang approved these changes

@jasper200207 jasper200207 jasper200207 approved these changes

@pipisebastian pipisebastian Awaiting requested review from pipisebastian

Assignees

@yeonddori yeonddori

Labels
📬 API 서버 API 통신
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API] 스터디 목록 조회 api 연결
4 participants
@yeonddori @jasper200207 @llddang @mun-kyeong