Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#324 팀생성 error handling #330

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Feature/#324 팀생성 error handling #330

merged 4 commits into from
Sep 27, 2024

Conversation

jasper200207
Copy link
Collaborator

관련 이슈

작업 요약

  • 팀 생성 혹은 수정 시 에러가 발생하면 alert 표시

작업 상세 설명

  • 팀 생성 혹은 수정 시 에러가 발생하면 alert 표시
  • 팀 생성시 유효성 검사를 건너띄고 api 호출하는 문제 수정

리뷰 요구 사항

  • 리뷰 예상 시간: 2분
  • 일단 alert로 해뒀는데 뭔가 찝찝해서 다른 방법이 있으면 수정하겠습니다

@jasper200207 jasper200207 added the 🐞 버그 예기치 못한 동작 발생 label Sep 27, 2024
@jasper200207 jasper200207 self-assigned this Sep 27, 2024
llddang
llddang approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@llddang llddang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

yeonddori
yeonddori reviewed Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@yeonddori yeonddori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헉.. 제 PR 때문에 충돌이 났네요..😅

yeonddori
yeonddori approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@yeonddori yeonddori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shaun

@jasper200207 jasper200207 merged commit a45a2cb into develop Sep 27, 2024
1 check passed
@jasper200207 jasper200207 deleted the Feature/#324-팀생성_error_handling branch September 27, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeonddori yeonddori yeonddori approved these changes

@llddang llddang llddang approved these changes

@mun-kyeong mun-kyeong Awaiting requested review from mun-kyeong

Assignees

@jasper200207 jasper200207

Labels
🐞 버그 예기치 못한 동작 발생
Projects
01-doo-re
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIX] 팀 생성이 안 될 경우 error handling
3 participants
@jasper200207 @llddang @yeonddori