Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[개발자 비상근무] 미니언 미션 제출합니다. #19

Open
wants to merge 1 commit into
base: gusah009-main
Choose a base branch
from

Conversation

gusah009
Copy link
Collaborator

산타 과제 끝나자마자 구현만 해놓고 PR 올리는걸 잊고있었네요...

상태를 가지는 클래스가 생기면서 개발이 더 복잡해지고 어려워 지는 것 같네요 ㅎㅎ

@gusah009 gusah009 requested review from shkisme and 02ggang9 March 10, 2024 01:09
@gusah009 gusah009 self-assigned this Mar 10, 2024
Copy link
Collaborator

@02ggang9 02ggang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오늘 라식해서 조금 뿌옇게 보이는데 선배님 코드는 뚜렷하게 보입니다..bb

스터디 완주해 주셔서 정말로 감사드리고 수고 많으셨습니다~~~!!

import java.time.DayOfWeek.*
import java.time.Month

class OncallDate(val month: Month, private val startDayOfWeek: DayOfWeek) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JDK 표준 라이브러리가 있는지 몰랐네요..!! 유용하게 잘 쓰겠습니다~!! bb

private var index = 0
private var queueMember: String? = null

fun getNextTurnMember(previousMember: String?) =
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

식이 본문인 함수 사용 bb 인 것 같습니다~!

return holidayMap.toMap()
}

private fun isHoliday(dayOfWeek: DayOfWeek, day: Int) = when (dayOfWeek) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리턴 타입이 Boolean 이라고 생각되게 만드는 메서드 명인 것 같습니다~!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants