Update staging #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 33f4ea2.
This reverts commit e1dbfd7.
This new model is based on the idea of having only one thread monitor the socket and then distribute the responses to every other thread that's waiting. Whenever a request is made, a new mpsc channel is created and added to an internal map. Then, if there are not other threads waiting for pending responses, that thread will become the "reader thread" and monitor the socket until it receives the response it was waiting for. In the meantime, if it sees responses coming on the socket with different ids, it will lookup the correct Sender from the internal map and send that message to the thread that created the request in the first place. The other threads will be waiting trying to read from their Receiver, where they will either get the message in response to their request, or a signal to wake up and become the new "reader thread".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.